Closed Bug 1407822 Opened 7 years ago Closed 7 years ago

SM builds are going to permafail when Gecko 58 merges to Beta on 2017-11-02

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 + verified

People

(Reporter: RyanVM, Assigned: nbp)

References

Details

Attachments

(1 file)

Remove BumpChunk::magic_ value when the assertion are removed.
2.19 KB, patch
jandem
: review+
RyanVM
: feedback+
Details | Diff | Splinter Review 
[Tracking Requested - why for this release]: SM bustage on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=136336667&repo=try

js/src/ds/LifoAlloc.h:220:21: error: private field 'magic_' is not used [-Werror,-Wunused-private-field]
Flags: needinfo?(nicolas.b.pierron)
Affects all clang-based opt builds.
Severity: normal → blocker
OS: Unspecified → All
Priority: -- → P1
Hardware: Unspecified → All
This should be an easy fix, I will make a patch later today.
Assignee: nobody → nicolas.b.pierron
Comment on attachment 8917947 [details] [diff] [review]
Remove BumpChunk::magic_ value when the assertion are removed.

Looks great on Try, thanks!
Flags: needinfo?(nicolas.b.pierron)
Attachment #8917947 - Flags: feedback+
Attachment #8917947 - Flags: review?(jdemooij) → review+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eab45e291bc0
Remove BumpChunk::magic_ value when the assertion are removed. r=jandem
https://hg.mozilla.org/mozilla-central/rev/eab45e291bc0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Status: RESOLVED → VERIFIED
status-firefox58: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: