1407832 - Stylo: Flags inherited by for_inheritance are suspicious

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Regarding flags in `StyleBuilder::for_inheritance`:

(Copied from Emilio Cobos Álvarez [:emilio] in bug 1406254 comment 9)
> Last, but not least, can you file a bug on our usage of `parent.flags` in
> that function and ni? me (or assign me directly)? Some of the flags aren't
> supposed to be "inherited", like INHERITS_RESET_STYLE / INHERITS_CONTENT.
> That's fishy, but it's not a problem right now because we only use them for
> element styles. It should get fixed though.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

ni? as requested.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Patch

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8918555 [details] [diff] [review]
Patch

Review of attachment 8918555 [details] [diff] [review]:
-----------------------------------------------------------------

::: components/style/matching.rs
@@ +365,1 @@
>              debug!(" > flags changed: {:?} != {:?}", old_values.flags, new_values.flags);

Maybe make this:

  debug!(" > inherited flags changed: {:?} != {:?}", old_values.flags.inherited(), new_values.flags.inherited());

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This landed.