Closed
Bug 1407887
Opened 7 years ago
Closed 7 years ago
Permission icons are smaller then the others in Preferences
Categories
(Firefox :: Settings UI, defect, P3)
Tracking
()
VERIFIED
FIXED
Firefox 58
People
(Reporter: HHuang, Assigned: evanxd)
Details
(Whiteboard: [photon-preference])
Attachments
(2 files)
Screenshot.png
The permission icons should be as big as all the icons in Preferences, please set the icon size to 20x20.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → evan
Status: NEW → ASSIGNED
|
||
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P3
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8921311 -
Flags: review?(mconley)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Hi Mike, Could you help review the patch? Thank you.
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8921311 [details] Bug 1407887 - Set the size of permission icons as 20x20px. https://reviewboard.mozilla.org/r/192316/#review197544 We already have a rule for .permission-icon, you probably just need to remove the max from max-{height/width} here: https://searchfox.org/mozilla-central/rev/d30462037ffea383e74c42542c820cf65b2b144e/browser/themes/shared/incontentprefs/privacy.css#6
Attachment #8921311 -
Flags: review-
|
||
Updated•7 years ago
|
Summary: Permission icons are smaller then the orthers in Preferences → Permission icons are smaller then the others in Preferences
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8921311 [details] Bug 1407887 - Set the size of permission icons as 20x20px. https://reviewboard.mozilla.org/r/192316/#review197816 Clearing r? - johannh got to this first.
Attachment #8921311 -
Flags: review?(mconley)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8921311 -
Flags: review?(mconley)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8921311 -
Flags: review?(jhofmann)
|
|
Assignee | |
Comment 7•7 years ago
|
||
Hi Johann, Thank you for the review. I've updated the patch for your comments. Could you please review it again? Thank you.
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8921311 [details] Bug 1407887 - Set the size of permission icons as 20x20px. https://reviewboard.mozilla.org/r/192316/#review197966 Looks great, thank you!
Attachment #8921311 -
Flags: review?(jhofmann) → review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/243740671440 Set the size of permission icons as 20x20px. r=johannh
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/243740671440
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Summary: Permission icons are smaller then the others in Preferences → Permission icons are smaller than the others in Preferences
|
||
Comment 11•7 years ago
|
||
Build ID: 20171026221945 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
status-firefox57:
--- → affected
Summary: Permission icons are smaller than the others in Preferences → Permission icons are smaller then the others in Preferences
|
||
Updated•7 years ago
|
|
|
||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•