1407906 - Make the filter by job field icon a toggle

Status: VERIFIED FIXED

(Tree Management :: Treeherder, enhancement, P3)

Description

[Jonathan French (:jfrench)]

The first thing I did when clicking on the new filter by job field icon in the navbar, was click on it a second time to close it, but nothing happened. So maybe it would be nice if the icon operated as a toggle.

It's possible we might not even need the existing 'Cancel' button in the form group, since the toggle behviour would close it.

I think I have it working, so I'll put up a PR in a bit.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:toggle-job-name-filter > mozilla:master

Comment 2

[Jonathan French (:jfrench)]

Comment on attachment 8917694 [details] [review]
[treeherder] tojon:toggle-job-name-filter > mozilla:master

For review at your leisure :)

Comment 3

[Jonathan French (:jfrench)]

Comment on attachment 8917694 [details] [review]
[treeherder] tojon:toggle-job-name-filter > mozilla:master

Pulling the r? for now, as I want to re-check unrelated bits regarding visibility really need to be the way they are.

Comment 4

[Jonathan French (:jfrench)]

Comment on attachment 8917694 [details] [review]
[treeherder] tojon:toggle-job-name-filter > mozilla:master

Ok, I've pushed a second commit with what I think is a better approach. If this is all good I will need to squash before merge. :)

Comment 5

[Jonathan French (:jfrench)]

Ok, I've squashed and I think it's ready for merge. I also put the final state of the branch on my gh-pages at the moment, at https://tojon.github.io/treeherder/dist if you want to re-check it. But it seems fine.

Comment 6

[Ed Morley [:emorley]]

Moving to P3 - we've just started using a system similar to that used for Firefox Bugzilla components where P4 is unused. (I'm going to be posting to the newsgroup about it more, but the rough gist is: P1 is for things being worked on this quarter, P2 is stretch goal for this quarter or else first in line for next quarter, P3 is main backlog [ie most bugs], P5 is "we won't be working on it ourselves, but would accept a PR if someone provides one, so not quite a wontfix", and P-- is "needs triage").

Comment 7

[Jonathan French (:jfrench)]

Ok, sounds good. Here's the list of my recent bugs which are P4/5's, among others I had entered and/or fixed the past week or so. Feel free to adjust them to the appropriate value of P3 or P5 as you see fit, and if the already Fixed ones below need to show up in any bugfix metrics and would otherwise not if they remained as P4's.

Bug 1408666, Bug 1408534, Bug 1407807, Bug 1407775.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ab8e99a22a811bcd0c19c9d7fe2fa16c59c25016
Bug 1407906 - Make the filter by job field icon a toggle

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 8917694 [details] [review]
[treeherder] tojon:toggle-job-name-filter > mozilla:master

Works awesome!  Thanks!

Comment 10

[Jonathan French (:jfrench)]

Verified fixed on production.