1407915 - Crash in java.lang.IllegalStateException: Page URL is required at org.mozilla.gecko.icons.IconRequestBuilder.build(IconRequestBuilder.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-0a44a468-32eb-4fca-ad29-06b160171012.
=============================================================

There are 140 crashes in nightly 58 with buildid 20171011100102. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1406338.
The crash is ranked #2 in nightly top-crashers for FennecAndroid.

[1] https://hg.mozilla.org/mozilla-central/rev/5e2772fd3b67

Comment 1

[Jing-wei Wu [:jwu]]

We should prevent loading favicon where the request URL is empty.

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1407915 - Ignore loading favicon without url.

Review commit: https://reviewboard.mozilla.org/r/188640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188640/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8917713 [details]
Bug 1407915 - Ignore loading favicon without url.

https://reviewboard.mozilla.org/r/188640/#review193918

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a322a6a0b07
Ignore loading favicon without url. r=nechen

Comment 5

[Jing-wei Wu [:jwu]]

Comment on attachment 8917713 [details]
Bug 1407915 - Ignore loading favicon without url.

Approval Request Comment
[Feature/Bug causing the regression]:
A regression caused by bug 1406338, we should prevent loading favicon when there is no valid URL.

[User impact if declined]:
If there is a tab contained empty URL, Fennec would crash when user enters tabs tray page.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes, here is the STR:

Prerequisite: Create a new tab with empty URL, however, I don't know how to create a tab without URL, perhaps you have to test several times.

1. Launch Fennec and press the 'tabs' button to enter tabs tray page,
2. Check if the favicon for each tab is shown correctly and app doesn't crash.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
We just add an error checking to prevent loading favicon if we get an empty URL.

[String changes made/needed]:
No

Comment 6

[Marcia Knous [:marcia]]

There seem to be many more crashes on 58 than on 57 - I see only one crash on 57 beta.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8917713 [details]
Bug 1407915 - Ignore loading favicon without url.

Low volume, low risk, new crash, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/56aea1e1ff32

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0a322a6a0b07