Closed Bug 1407917 Opened 3 years ago Closed 3 years ago

Simplify DDLogger string-logging functions

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

DecoderDoctorLogger functions taking literal strings could be simplified by just taking a `const char*`.

Also the non-"Eager" versions should be removed, they're confusing and don't add much value.

(Thank you JW for the suggestion.)
Comment on attachment 8917708 [details]
Bug 1407917 - Simplify DDLogger string-logging functions -

https://reviewboard.mozilla.org/r/188636/#review193874
Attachment #8917708 - Flags: review?(jwwang) → review+
Thank you again JW for the quick review.
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26da99ae0203
Simplify DDLogger string-logging functions - r=jwwang
https://hg.mozilla.org/mozilla-central/rev/26da99ae0203
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.