1407937 - Move mDefinition from CustomElementReacion to CustomElementUpgradeReaction

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Edgar Chen [:edgar]]

mDefinition [1] is only used in CustomElementUpgradeReaction, so we could consider move it from CustomElementReacion to CustomElementUpgradeReaction.

[1] http://searchfox.org/mozilla-central/rev/31606bbabc50b08895d843b9f5f3da938ccdfbbf/dom/base/CustomElementRegistry.h#229

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b88fd4bbe4b4081a14e4d048015bfa0b459939e9

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 3

[John Dai[:jdai]]

Comment on attachment 8917839 [details] [diff] [review]
Patch, v2

Review of attachment 8917839 [details] [diff] [review]:
-----------------------------------------------------------------

Overall it looks good. Thank you.

::: dom/base/CustomElementRegistry.h
@@ +213,5 @@
>  
>  class CustomElementReaction
>  {
>  public:
> +  CustomElementReaction()

Nit: Please remove this line. We don't need to write a default CTOR in here.

@@ +228,5 @@
>  class CustomElementUpgradeReaction final : public CustomElementReaction
>  {
>  public:
>    explicit CustomElementUpgradeReaction(CustomElementDefinition* aDefinition)
> +    : CustomElementReaction()

Nit: Please remove this line.

@@ +243,5 @@
>  class CustomElementCallbackReaction final : public CustomElementReaction
>  {
>    public:
> +    explicit CustomElementCallbackReaction(UniquePtr<CustomElementCallback> aCustomElementCallback)
> +      : CustomElementReaction()

Nit: Please remove this line.

Comment 4

[Edgar Chen [:edgar]]

Attachment: Patch, v3, f=jdai

Address comment #3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f3731e3864d
Move mDefinition from CustomElementReacion to CustomElementUpgradeReaction; f=jdai; r=smaug

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7f3731e3864d