Closed
Bug 1407954
Opened 8 years ago
Closed 8 years ago
Links are not highlighted when long pressing on them
Categories
(Firefox for iOS :: General, defect, P1)
Tracking
()
People
(Reporter: csuciu, Assigned: justindarc)
Details
Attachments
(1 file)
latest master
v9.2 (6679)
* Go to www.bbc.com and long press on a link
Expected: The link is highlighted
Actual: The link is not highlighted
I suspect this regressed from https://github.com/mozilla-mobile/firefox-ios/commit/12290b745248e5b40913aeb1aa7518ff68067a17
|
Reporter | |
Updated•8 years ago
|
QA Whiteboard: justin
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
QA Whiteboard: justin
Priority: -- → P1
|
|
Assignee | |
Comment 1•8 years ago
|
||
This patch gets rid of all of the JS code that was previously detecting the long-press gesture and instead passes up just the <a>/<img> info on `touchstart`. From there, we just redirect the native `UIGestureRecognizer` in the `WKWebView` to target our own helper. This approach makes it impossible for the original native context menu to ever appear and essentially lets us hijack the native behavior for our own context menu.
Attachment #8918426 -
Flags: review?(fpatel)
|
||
Updated•8 years ago
|
Attachment #8918426 -
Flags: review?(fpatel) → review+
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 2•8 years ago
|
||
Verified as fixed on master 20ebe179 on iOS 10.3.3 & 11.0.3
|
||
Comment 4•8 years ago
|
||
This also landed on v9.x
|
|
Reporter | |
Comment 5•8 years ago
|
||
Verified as fixed on v9.3 (7374) on iOS 10.3.3 & 11.0.3
|
|
Reporter | |
Updated•8 years ago
|
status-fxios-v9.2:
verified → ---
status-fxios-v9.3:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•