1407967 - ESLint: lz4 tests are comparing some values to themselves

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Mark Banner (:standard8)]

In bug 1371293 I'm working on upgrading us to ESLint 4. Currently I'm seeing these errors:

toolkit/components/lz4/tests/xpcshell/data/worker_lz4.js
  76:10  error  Comparing to itself is potentially pointless.  no-self-compare (eslint)

toolkit/components/lz4/tests/xpcshell/test_lz4_sync.js
  9:10  error  Comparing to itself is potentially pointless.  no-self-compare (eslint)

In this case the functions that are affected are comparison functions which are accidentally comparing an item to itself.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1407967 - Fix comparison checks in lz4 tests incorrectly comparing arrays to themselves.

Review commit: https://reviewboard.mozilla.org/r/188728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188728/

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8917788 [details]
Bug 1407967 - Fix comparison checks in lz4 tests incorrectly comparing arrays to themselves.

https://reviewboard.mozilla.org/r/188728/#review194094

Ouch. Good catch.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8917788 [details]
Bug 1407967 - Fix comparison checks in lz4 tests incorrectly comparing arrays to themselves.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188728/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1225e35f570
Fix comparison checks in lz4 tests incorrectly comparing arrays to themselves. r=Yoric

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d1225e35f570