Closed
Bug 1407981
Opened 7 years ago
Closed 7 years ago
WEBCONSOLE_L10N is not used
Categories
(DevTools :: Netmonitor, enhancement, P3)
DevTools
Netmonitor
Tracking
(firefox57 fix-optional, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fix-optional |
| firefox58 | --- | fixed |
People
(Reporter: gasolin, Assigned: amorris2003, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][mentor-lang=zh][lang=js])
Attachments
(1 file, 2 obsolete files)
|
864 bytes,
patch
|
gasolin
:
review+
|
Details | Diff | Splinter Review |
WEBCONSOLE_L10N is not used anywhere in netmonitor http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/utils/l10n.js#13 we can safely remove related declaration in l10n.js
|
Reporter | |
Comment 1•7 years ago
|
||
This is a 2 lines change bug, suit for the first time contributor to familar with mozilla's toolchain
Keywords: good-first-bug
Whiteboard: [good first bug][mentor-lang=zh][lang=js]
|
||
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
Priority: -- → P3
|
Assignee | |
Comment 2•7 years ago
|
||
Working on it.
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8918527 -
Flags: review?(gasolin)
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8918527 -
Attachment is obsolete: true
Attachment #8918527 -
Flags: review?(gasolin)
Attachment #8918528 -
Flags: review?(gasolin)
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8918528 -
Attachment is obsolete: true
Attachment #8918528 -
Flags: review?(gasolin)
Attachment #8918530 -
Flags: review?(gasolin)
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → amorris2003
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 6•7 years ago
|
||
Comment on attachment 8918530 [details] [diff] [review] 1407981.patch Looks good, thanks for contribute!
Attachment #8918530 -
Flags: review?(gasolin) → review+
|
|
Reporter | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3f2e01a2196a Removed unused WEBCONSOLE_L10N reference. r=gasolin
Keywords: checkin-needed
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3f2e01a2196a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•