1408079 - Light theme in FF58 has wrong height or looks odd

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[u595893]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171012105833

Steps to reproduce:

New profile

Switch to light theme(happens in default/light but easy to see in light dark one is not affected)


Actual results:

Tabs look odd when selected


Expected results:

Should be similar to Dark one

Comment 1

[u595893]

Attachment: light with problem dark with no problem.jpg

Comment 2

[Dão Gottwald [:dao]]

Is this a regression?

Comment 3

[u595893]

(In reply to Dão Gottwald [::dao] from comment #2)
> Is this a regression?

maybe bug 1404074

Happen in FF57 too

Comment 4

[Dão Gottwald [:dao]]

(In reply to shellye from comment #0)
> Actual results:
> 
> Tabs look odd when selected

Can you say more specifically how this look odd? I don't really see anything wrong in your screenshot.

Comment 5

[u595893]

(In reply to Dão Gottwald [::dao] from comment #4)
> (In reply to shellye from comment #0)
> > Actual results:
> > 
> > Tabs look odd when selected
> 
> Can you say more specifically how this look odd? I don't really see anything
> wrong in your screenshot.

Tab1 Tab2 Tab3

select Tab2

see the height look like it's being pressed from above(compare with dark which looks ok)
compact density is set

Comment 6

[Edo Karabas]

I don't know, everything looks okay to me to be honest. Isn't it just your feeling due to different contrast ?

Comment 7

[u595893]

(In reply to Eddward from comment #6)
> I don't know, everything looks okay to me to be honest. Isn't it just your
> feeling due to different contrast ?

Not sure
looking at the tab sandwiched in between two from bottom up it looks like the selected tab is pushed way down, feels like it is dropping

Comment 8

[u595893]

Just look at the screenshot and see the dark one then compare with light one,
the tab looks odd(maybe dark one blends the upper line/borders better?)

Comment 9

[u595893]

Attachment: attachment.jpg

The dark one has better look and blends well

Comment 10

[Johann Hofmann [:johannh]]

There's no issue here, that's how it was designed. Sorry that this doesn't match your personal taste, but we're not going to adjust the separator color.

Comment 11

[u595893]

Attachment: 20170921 build with the problem not present

This bulid does not have the problem,
so it's not about personal taste.

Something changed to make it appear bolder or it's the thicker blue line
which makes it look like it's falling from tab bar

Comment 12

[u595893]

Or the padding under the tab is lesser which makes it look sleeker,
or a combination of both.

Comment 13

[Johann Hofmann [:johannh]]

(In reply to shellye from comment #11)
> Created attachment 8918526 [details]
> 20170921 build with the problem not present
> 
> This bulid does not have the problem,
> so it's not about personal taste.
> 
> Something changed to make it appear bolder or it's the thicker blue line
> which makes it look like it's falling from tab bar

I'm not sure what to do here and I don't really understand the screenshot. What part of it looks right to you and what doesn't? 

You can find a Photon mockup here: http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html

If it looks like that, it's not a bug. If it doesn't, please let us know.

Comment 14

[u595893]

(In reply to Johann Hofmann [:johannh] from comment #13)
> (In reply to shellye from comment #11)
> > Created attachment 8918526 [details]
> > 20170921 build with the problem not present
> > 
> > This bulid does not have the problem,
> > so it's not about personal taste.
> > 
> > Something changed to make it appear bolder or it's the thicker blue line
> > which makes it look like it's falling from tab bar
> 
> I'm not sure what to do here and I don't really understand the screenshot.
> What part of it looks right to you and what doesn't? 
> 
> You can find a Photon mockup here:
> http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html
> 
> If it looks like that, it's not a bug. If it doesn't, please let us know.

on lower resolution it seems different from the mockups 
The highlight above the tab is wider
The space between & besides the tab is more padded making it appear falling
can you test on that?

Comment 15

[Johann Hofmann [:johannh]]

To be honest I'm not sure what to do about this. I'm not able to tell the problem by looking at that screenshot. The problem may be visible to you in context of your entire screen, but it's not to me. The image is very low-res (which may not be your fault because you're saying this only happens on low resolution), but I don't think this is actionable in its current state. It could be that you're reporting a valid rendering issue. Can you provide your display scale and resolution settings?