Closed Bug 1408110 Opened 2 years ago Closed 2 years ago

Deal with tabs that force a modal

Categories

(WebExtensions :: Frontend, enhancement, P3)

enhancement

Tracking

(firefox57 wontfix)

RESOLVED INVALID
Tracking Status
firefox57 --- wontfix

People

(Reporter: andy+bugzilla, Assigned: mixedpuppy)

References

(Blocks 2 open bugs)

Details

If a tab triggers a modal dialog then the tab will need to be shown. An example is when a tab triggers a HTTP auth dialog.

If the tab strip is hidden, as per bug 1332447 this isn't a problem the tab with a dialog is shown.

With bug 1384515 the tab will need to be shown to the user. Perhaps when this happens we just force the tab to visible and let the add-on deal with this.
Priority: -- → P3
Please: 

- does this bug block LastPass working with modals in Firefox Quantum?

Related: <https://discourse.mozilla.org/t/-/19745/8?u=grahamperrin>
Assignee: nobody → mixedpuppy
(In reply to Graham Perrin from comment #1)
> Please: 
> 
> - does this bug block LastPass working with modals in Firefox Quantum?
> 
> Related: <https://discourse.mozilla.org/t/-/19745/8?u=grahamperrin>

No, its unrelated.
"If a tab triggers a modal dialog then the tab will need to be shown."

This already happens for all modal dialogs associated with a tab.  DOMWillOpenModalDialog event is fired and captured by tabbrowser.js.  The selected tab is set which forces the tab to be visible.  Surprisingly (to me anyway) it happens for tab modal dialogs as well.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.