Closed Bug 1408116 Opened 3 years ago Closed 3 years ago

Some filters (e.g. contrast()) don't deal with premultiplied alpha correctly

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- verified
firefox60 --- verified

People

(Reporter: mstange, Assigned: ethlin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-mvp])

Attachments

(1 file)

testcase
384 bytes, text/html
Details
Attached file testcase — 
In this testcase, both boxes should look the same.
Whiteboard: [wr-mvp] [triage]
Priority: -- → P2
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
Priority: P2 → P3
Whiteboard: [wr-mvp] → [wr-reserve]
Testcase: attachment 8917939 [details]

mozregression --find-fix --bad 2017-10-12 --good 2017-11-18 --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"
> 11:54.27 INFO: First good revision: cdf4bb1c6af6e53643d2beb0f10a2ce29207ff5e
> 11:54.27 INFO: Last bad revision: ef9858e9ad38718eea180a62bb5b65561ad57d91
> 11:54.27 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef9858e9ad38718eea180a62bb5b65561ad57d91&tochange=cdf4bb1c6af6e53643d2beb0f10a2ce29207ff5e

> cdf4bb1c6af6	Kartikaya Gupta — Bug 1417062 - Update for API change in WR PR 2043. r=nical
> 72cfd88fe0a0	Kartikaya Gupta — Bug 1417062 - Update reftest annotations for changes in WR PR 2031. r=nical
> c80c224d6b0c	Kartikaya Gupta — Bug 1417062 - Update webrender to commit d490a74c438d987122c600afca6bb2247ab38637. r=nical

https://github.com/servo/webrender/compare/8a39cf24f493e894a66c2465dd310a2b2923e558...d490a74c438d987122c600afca6bb2247ab38637
Depends on: 1417062
Status: NEW → RESOLVED
Has STR: --- → yes
Closed: 3 years ago
status-firefox59: --- → fixed
Resolution: --- → WORKSFORME
Priority: P3 → --
Whiteboard: [wr-reserve]
This was fixed by https://github.com/servo/webrender/pull/2048 . Thanks Ethan!
Assignee: nobody → ethlin
Priority: -- → P3
Resolution: WORKSFORME → FIXED
Whiteboard: [wr-reserve]
Whiteboard: [wr-reserve]
Priority: P3 → P1
Whiteboard: [wr-mvp]
QA Whiteboard: [good first verify]
I successfully reproduced the issue on Firefox Nightly 58.0a1 (2017-10-12) under macOS 10.12.6 using the attachment from Comment 0.

The issue is no longer reproducible on Firefox 59 RC and Firefox Nightly 60.0a1 (2018-03-12) under Windows 10 (x64), Ubuntu 16.04.3 (x64) and macOS 10.12.6.
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
status-firefox60: --- → verified
You need to log in before you can comment on or make changes to this bug.