1408127 - Integrate a pre-processor for user scripts

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement, P2)

Description

[Justin D'Arcangelo [:justindarc]]

To improve developer ergonomics and webview performance, our user scripts should be concatenated and minified using a JavaScript pre-processor. This would allow us to use ES7 modules for code reusability while drastically reducing the overall number and size of scripts injected into the webview.

At an initial glance, it seems that we need to consider at least 4 groupings of user scripts:
- onDocumentStart (per frame)
- onDocumentStart (per window)
- onDocumentEnd (per frame)
- onDocumentEnd (per window)

In order to make integration seamless from a developer's standpoint, I propose that we categorize our user scripts into separate folders in Xcode based on the 4 groupings above. This would allow us to simply hook our pre-processor into a Build Phase in Xcode so that these scripts are compiled automatically at build-time.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Assigning to myself for v11.0 as per discussion in today's TDES meeting. Marking as P2 for now until I begin actively working on this.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 3

[:garvan]

Comment on attachment 8943355 [details] [review]
GitHub Pull Request

r+

I am following up with a BB validation step in https://bugzilla.mozilla.org/show_bug.cgi?id=1431751 and I'll ping you for review

Comment 4

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/2d5ca06880b9288be74b7eb1a6cb7c937292387d