Remove unused probe NEWTAB_PAGE_LIFE_SPAN_SUGGESTED

RESOLVED FIXED in Firefox 58

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: chutten, Assigned: amorris2003, Mentored)

Tracking

Trunk
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
It should've been removed as a part of bug 1241390 which removed the suggested tiles feature.

Remove from the following locations:
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json

Then ensure that ./mach eslint -wo succeeds and you can still build Firefox.
(Assignee)

Comment 1

2 years ago
Posted patch 1408134.patchSplinter Review
Attachment #8918531 - Flags: review?(chutten)
(Reporter)

Updated

2 years ago
Attachment #8918531 - Flags: review?(chutten) → review+
(Reporter)

Comment 2

2 years ago
Thanks, this looks great! I've marked it for push into the tree. With luck your contribution will be in the next build of Firefox Nightly.

Would you like any help finding more bugs to fix?
Assignee: nobody → amorris2003
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05cd36743f31
Remove unused probe NEWTAB_PAGE_LIFE_SPAN_SUGGESTED. r=chutten
Keywords: checkin-needed
Depends on: 1409411
https://hg.mozilla.org/mozilla-central/rev/05cd36743f31
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
No longer depends on: 1409411
You need to log in before you can comment on or make changes to this bug.