Closed Bug 1408134 Opened 3 years ago Closed 3 years ago

Remove unused probe NEWTAB_PAGE_LIFE_SPAN_SUGGESTED

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: chutten, Assigned: amorris2003, Mentored)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

It should've been removed as a part of bug 1241390 which removed the suggested tiles feature.

Remove from the following locations:
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json

Then ensure that ./mach eslint -wo succeeds and you can still build Firefox.
Attached patch 1408134.patchSplinter Review
Attachment #8918531 - Flags: review?(chutten)
Attachment #8918531 - Flags: review?(chutten) → review+
Thanks, this looks great! I've marked it for push into the tree. With luck your contribution will be in the next build of Firefox Nightly.

Would you like any help finding more bugs to fix?
Assignee: nobody → amorris2003
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05cd36743f31
Remove unused probe NEWTAB_PAGE_LIFE_SPAN_SUGGESTED. r=chutten
Keywords: checkin-needed
Depends on: 1409411
https://hg.mozilla.org/mozilla-central/rev/05cd36743f31
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
No longer depends on: 1409411
You need to log in before you can comment on or make changes to this bug.