Closed
Bug 1408143
Opened 8 years ago
Closed 8 years ago
JSON Viewer: navigable (clickable) links (enhancement proposal)
Categories
(DevTools :: JSON Viewer, defect)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: alek.gurin, Assigned: alek.gurin)
Details
Attachments
(1 file)
|
817 bytes,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171009192146
|
Assignee | |
Comment 1•8 years ago
|
||
It would be convenient to have navigable links in JSON viewer. It's really helpful when you browser REST API (e.g. https://api.github.com/).
Attachment #8917982 -
Flags: review?(pbrosset)
|
|
Assignee | |
Updated•8 years ago
|
Component: Untriaged → Developer Tools: JSON Viewer
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8917982 [details] [diff] [review]
json-viewer-clickable-links.patch
Thanks a lot for the patch Aleksander. I'm passing this on to Honza who knows the jsonviewer better than I do.
Attachment #8917982 -
Flags: review?(pbrosset) → review?(odvarko)
|
|
Assignee | |
Comment 3•8 years ago
|
||
OK, Patrick. Thank a lot for quick answer.
|
||
Comment 4•8 years ago
|
||
Should this wait until https://github.com/devtools-html/devtools-core/issues/616 is fixed?
|
|
Assignee | |
Comment 5•8 years ago
|
||
It could wait, but my issue is independent (as you can see it is in the code of JSON Viewer, not in Rep library).
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8917982 [details] [diff] [review]
json-viewer-clickable-links.patch
Review of attachment 8917982 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, thanks for the patch!
R+ (assuming try is green)
Honza
Attachment #8917982 -
Flags: review?(odvarko) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Thanks, Jan. Do I need to do something more, or this patch will be added by someone (or maybe by build system)?
|
|
||
Comment 8•8 years ago
|
||
You can add the checkin-needed keyword. See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
|
||
Updated•8 years ago
|
Assignee: nobody → alek.gurin
|
|
||
Updated•8 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d18dc098eda
JSON Viewer: navigable (clickable) links (enhancement proposal). r=Honza
Keywords: checkin-needed
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Comment 11•7 years ago
|
||
[bugday-20180110]
The issue is no longer reproducible on Firefox 58.0b14 (64-bit)(Build Id: 20180103230655).
Tested in Linux debain 4.10.0-38-generic #42~16.04.1-Ubuntu x86_64
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•