1408146 - Port bug 1391539 to TB: Show tab separators when hovering tabs

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

FX added to show borders on the sides when hovering them.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: tabHoverBorder.patch

This is a port of https://hg.mozilla.org/mozilla-central/rev/40ef1df3618b.

The difference to today is that the last tab has on the right a separator too and when you hover over a tab you will have a border on the right/left. When ayou hove rover a tab beside of a selected tab you see no new border at the selected tab's side.

Comment 2

[Jorg K (CEST = GMT+2)]

Hmm, another bug where I need to work out what's right first.

On a recent Daily I see this in Windows 7 with a menu bar and tabs not in the titlebar:
The tabs have separators which are slightly shorter than full height. When you hover one, its background changes and the separators disappear.

With the patch the separators don't disappear but instead turn into a full-height separator. I think that's the desired effect. However, the last (right-most) tab which currently doesn't have a separator on the right also does not receive a border when hovered with the patch applied.

I don't quite understand comment #1. The last [right-most] tab doesn't receive a right separator, although I think it should.

Comment 3

[Jorg K (CEST = GMT+2)]

Same behaviour without a menu and tabs in titlebar: The right-most tab never gets a right border.

Comment 4

[Jorg K (CEST = GMT+2)]

I downloaded a FF Nightly. Very hard to say what that does since inactive tabs are almost black. I think the right-most tab shows no right border when inactive and none appears when hovered.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Win7-separators.png

(In reply to Jorg K (GMT+2) from comment #2)
> Hmm, another bug where I need to work out what's right first.
> 
> On a recent Daily I see this in Windows 7 with a menu bar and tabs not in
> the titlebar:
> The tabs have separators which are slightly shorter than full height. When
> you hover one, its background changes and the separators disappear.

Correct

> With the patch the separators don't disappear but instead turn into a
> full-height separator. I think that's the desired effect. However, the last
> (right-most) tab which currently doesn't have a separator on the right also
> does not receive a border when hovered with the patch applied.

Strange, as you can see in my screenshot, the right-most tab has a separator on the right which turns also in a border when hovering/selecting.

> I don't quite understand comment #1. The last [right-most] tab doesn't
> receive a right separator, although I think it should.

Without patch, no separator on the right of the last tab. With patch, a separator, like in my screenshot.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #4)
> I downloaded a FF Nightly. Very hard to say what that does since inactive
> tabs are almost black. I think the right-most tab shows no right border when
> inactive and none appears when hovered.

This background looks weird, no?

Comment 7

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #5)
> With patch, a separator, like in my screenshot.
Close the add-ons tab and restart.

As soon as I open the add-on manager, the right border is there. And it stays even if I now close the add-on manager. But it's gone when I restart.

Do you want a screenshot or do you believe me? ;-)

Comment 8

[Richard Marti (:Paenglab)]

Attachment: tabHoverBorder.patch

Oh, I believe you. I needed only a STR. :)

The 'last-tab' attribute isn't set with only two tabs. With only one tab, the tab has the 'first-tab' and 'last-tab' attributes ;). I use now the :last-child selector.

I think, we should file a bug to fix this 'last-tab' attribute

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8918569 [details] [diff] [review]
tabHoverBorder.patch

Yes, this works now and is nice. Please file a bug for the issue we discovered.

Comment 10

[Richard Marti (:Paenglab)]

Thanks.

Checked in FX and 'last-tab' is wrongly set too.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0a52075ec95b
Port bug 1391539 to TB: Show tab separators when hovering tabs. r=jorgk