1408154 - Use SVG icons for the AppMenu

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

We still use PNG or GTK icons for the menuitems in the AppMenu. We should switch to SVG icons.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: AppMenuSVG.patch

The most impact is on Linux.

Only some items in the AppMenu have now icons. I leaved the other icons on the main menu as they are.

Aceman, what do you think, should we also remove this icons in the normal menus? FX has no icons in the main menu.

Comment 2

[:aceman]

But Firefox has a ton of icons in the Appmenu, why are you removing them here?
I think we can leave main menu icons for now. They seem to come from Gtk so they may be useful for desktop consistency.

Comment 3

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #2)
> But Firefox has a ton of icons in the Appmenu, why are you removing them
> here?

I removed the Gtk icon from the AppMenu because they don't fit well with our icons. If we had fitting icons, I would use them. But only adding new icons for Linux's AppMenu seems to be overkill now. And our AppMenu isn't the same as the FX one with the panel.

> I think we can leave main menu icons for now. They seem to come from Gtk so
> they may be useful for desktop consistency.

Okay.

Comment 4

[Richard Marti (:Paenglab)]

Aceman, gentle review ping.

Comment 5

[:aceman]

Comment on attachment 8917987 [details] [diff] [review]
AppMenuSVG.patch

Review of attachment 8917987 [details] [diff] [review]:
-----------------------------------------------------------------

OK, it doesn't break Linux build ;)

Comment 6

[Richard Marti (:Paenglab)]

Thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d25546081788
Use SVG icons for the AppMenu. r=aceman