1408174 - The scene is rebuilt everytime we scroll

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

The following code causes this:

                // Ideally, when there are property bindings present,
                // we won't need to rebuild the entire frame here.
                // However, to avoid conflicts with the ongoing work to
                // refactor how scroll roots + transforms work, this
                // just rebuilds the frame if there are animated property
                // bindings present for now.
                // TODO(gw): Once the scrolling / reference frame changes
                //           are completed, optimize the internals of
                //           animated properties to not require a full
                //           rebuild of the frame!
                if let Some(property_bindings) = property_bindings {
                    doc.scene.properties.set_properties(property_bindings);
                    doc.build_scene(&mut self.resource_cache);
                }

Comment 1

[Kartikaya Gupta (email:[e-mail])]

The code quoted in comment 1 is at http://searchfox.org/mozilla-central/rev/d30462037ffea383e74c42542c820cf65b2b144e/gfx/webrender/src/render_backend.rs#391-404

I filed a issue in upstream WR since that's where the fix will probably go.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The fix for servo/webrender#1921 already landed in m-c, as part of the update in bug 1417062. So this should be fixed already.