Closed Bug 1408174 Opened 2 years ago Closed 2 years ago

The scene is rebuilt everytime we scroll

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: jrmuizel, Assigned: gw)

References

Details

(Whiteboard: [wr-reserve])

The following code causes this:

                // Ideally, when there are property bindings present,
                // we won't need to rebuild the entire frame here.
                // However, to avoid conflicts with the ongoing work to
                // refactor how scroll roots + transforms work, this
                // just rebuilds the frame if there are animated property
                // bindings present for now.
                // TODO(gw): Once the scrolling / reference frame changes
                //           are completed, optimize the internals of
                //           animated properties to not require a full
                //           rebuild of the frame!
                if let Some(property_bindings) = property_bindings {
                    doc.scene.properties.set_properties(property_bindings);
                    doc.build_scene(&mut self.resource_cache);
                }
Whiteboard: [wr-mvp] [triage]
Priority: P1 → P2
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
See Also: → 1410557
Blocks: 1412731
Priority: P2 → P3
Whiteboard: [wr-mvp] → [wr-reserve]
The fix for servo/webrender#1921 already landed in m-c, as part of the update in bug 1417062. So this should be fixed already.
Assignee: nobody → gwatson
Status: NEW → RESOLVED
Closed: 2 years ago
Depends on: 1417062
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.