Closed Bug 1408179 Opened 4 years ago Closed 4 years ago

langpack manifest data isn't actually being stored in the startup cache

Categories

(Toolkit :: Add-ons Manager, enhancement)

56 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: aswan, Assigned: aswan)

Details

Attachments

(1 file)

I think the basic problem is that we're not creating a good cache key here:
http://searchfox.org/mozilla-central/rev/ed1d5223adcdc07e9a2589ee20f4e5ee91b4df10/toolkit/components/extensions/Extension.jsm#1657

neither this.id or this.version are defined in the Langpack class.  And I'm not sure we need the current locale as a cache key for langpacks, that is in extension cache keys since their manifest contents can be localized and we don't want to re-use cache entries when the browser locale changes.
I think the change is as simple as to pluck the id and version from addonData and use them for the cache key, I'll give that a try.
Assignee: nobody → aswan
Attachment #8918027 - Flags: review?(gandalf)
Comment on attachment 8918027 [details]
Bug 1408179 Fix manifestCacheKey for langpacks

https://reviewboard.mozilla.org/r/188924/#review194234

Fixes the bug in my manual testing :)
Attachment #8918027 - Flags: review?(gandalf) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adb9c07370c6
Fix manifestCacheKey for langpacks r=gandalf
https://hg.mozilla.org/mozilla-central/rev/adb9c07370c6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Is manual testing required on this bug? If yes, please provide some STR and the proper webextension(if required) or set the “qe-verify-“ flag.
Flags: needinfo?(aswan)
Manual testing is slightly tricky, I think the manual testing mentioned in comment 2 should be adequate.
Flags: needinfo?(aswan)
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.