1408179 - langpack manifest data isn't actually being stored in the startup cache

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Andrew Swan [:aswan]]

I think the basic problem is that we're not creating a good cache key here:
http://searchfox.org/mozilla-central/rev/ed1d5223adcdc07e9a2589ee20f4e5ee91b4df10/toolkit/components/extensions/Extension.jsm#1657

neither this.id or this.version are defined in the Langpack class.  And I'm not sure we need the current locale as a cache key for langpacks, that is in extension cache keys since their manifest contents can be localized and we don't want to re-use cache entries when the browser locale changes.
I think the change is as simple as to pluck the id and version from addonData and use them for the cache key, I'll give that a try.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1408179 Fix manifestCacheKey for langpacks

Review commit: https://reviewboard.mozilla.org/r/188924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188924/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8918027 [details]
Bug 1408179 Fix manifestCacheKey for langpacks

https://reviewboard.mozilla.org/r/188924/#review194234

Fixes the bug in my manual testing :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adb9c07370c6
Fix manifestCacheKey for langpacks r=gandalf

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/adb9c07370c6

Comment 5

[marius.santa]

Is manual testing required on this bug? If yes, please provide some STR and the proper webextension(if required) or set the “qe-verify-“ flag.

Comment 6

[Andrew Swan [:aswan]]

Manual testing is slightly tricky, I think the manual testing mentioned in comment 2 should be adequate.