Closed
Bug 1408180
Opened 7 years ago
Closed 7 years ago
Implement cleartextToString for LoginRec to avoid ever logging passwords.
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: tcsc, Assigned: tcsc)
Details
Attachments
(1 file)
Similar to how we do for https://searchfox.org/mozilla-central/source/browser/extensions/formautofill/FormAutofillSync.jsm#67-71. I don't *think* we do this, but bug 1408176 made me think of it. It's also possible we do log these on trace level...
|
Assignee | |
Comment 1•7 years ago
|
||
This is actually kinda bad that we don't so I'm just going to do it now, even though it might be goodfirstbug material.
Assignee: nobody → tchiovoloni
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8918023 [details] Bug 1408180 - Ensure LoginRec.toString doesn't contain the password. https://reviewboard.mozilla.org/r/188912/#review194226 Awesome, thanks!
Attachment #8918023 -
Flags: review?(kit) → review+
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c38729d10244 Ensure LoginRec.toString doesn't contain the password. r=kitcambridge
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c38729d10244
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•