Closed Bug 1408204 Opened 2 years ago Closed 2 years ago

Honor client.py repository defaults in automation.

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: tomprince, Assigned: tomprince)

Details

Attachments

(1 file)

client.py tries to guess the remote mozilla repository to update from based on where an existing repository was already cloned from. This makes sense when it is being run locally. But when run on buildbot (on try-comm-central for example), the configuration in client.py should honored, rather than whatever repository happened to have been cloned there last.
Assignee: nobody → mozilla
Comment on attachment 8918044 [details]
Bug 1408204: Always use MOZILLA_REPO from client.py in automation.

https://reviewboard.mozilla.org/r/188938/#review194410

Stealing the review here since Joshua is usually quite busy, r=philipp
Attachment #8918044 - Flags: review+
Attachment #8918044 - Flags: review?(Pidgeot18)
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/4dd3dca99031
Always use MOZILLA_REPO from client.py in automation; r=Fallen DONTBUILD CLOSED TREE
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
This would be useful to backport to comm-beta and comm-esr52, to make it easier to run try builds against them.
Flags: needinfo?(jorgk)
Comment on attachment 8918044 [details]
Bug 1408204: Always use MOZILLA_REPO from client.py in automation.

Sure. The simple way is to request uplift against the patch or review request and I'll take care of it.
Flags: needinfo?(jorgk)
Attachment #8918044 - Flags: approval-comm-esr52+
Attachment #8918044 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 58.0
Comment on attachment 8918044 [details]
Bug 1408204: Always use MOZILLA_REPO from client.py in automation.

Without a target, no query ever found this bug :-(
Attachment #8918044 - Flags: approval-comm-esr52+
Attachment #8918044 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.