1408205 - Send to Device icon in the Page Action Menu needs to be updated

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[bbell]

Attachment: example.png

The Icon for 'Send to Device' needs an update. See Example.

Comment 1

[bbell]

Attachment: send-to-device.svg

Icon needed.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1408205 - Change the icon for the 'Send To Device' page-action.

Review commit: https://reviewboard.mozilla.org/r/191162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191162/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8920165 [details]
Bug 1408205 - Change the icon for the 'Send To Device' page-action.

https://reviewboard.mozilla.org/r/191162/#review196484

::: browser/themes/shared/icons/send-to-device.svg:4
(Diff revision 1)
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">

I think you should be able to remove the viewBox attribute here.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Send to device in RTL

This should probably point the other way in RTL?

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8920165 [details]
Bug 1408205 - Change the icon for the 'Send To Device' page-action.

https://reviewboard.mozilla.org/r/191162/#review196562

::: browser/themes/shared/urlbar-searchbar.inc.css:128
(Diff revision 1)
>  }
>  
>  .pageAction-sendToDevice-device[clientType=mobile] {
> -  list-style-image: url("chrome://browser/skin/device-mobile.svg");
> +  list-style-image: url("chrome://browser/skin/send-to-device.svg");
>  }
>  

nit: (or follow-up) this new icon is directional and should probably point to the left in RTL with a :-moz-locale-dir(rtl) rule.

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8920165 [details]
Bug 1408205 - Change the icon for the 'Send To Device' page-action.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191162/diff/1-2/

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 8920165 [details]
Bug 1408205 - Change the icon for the 'Send To Device' page-action.

https://reviewboard.mozilla.org/r/191162/#review196484

> I think you should be able to remove the viewBox attribute here.

UX has stated that it's preferable to keep this attribute, because it makes (pre)viewing outside of Firefox easier.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ec97e588099
Change the icon for the 'Send To Device' page-action. r=jaws,sfoster

Comment 9

[Mike de Boer [:mikedeboer]]

(In reply to Sam Foster [:sfoster] from comment #5)
> nit: (or follow-up) this new icon is directional and should probably point
> to the left in RTL with a :-moz-locale-dir(rtl) rule.

Thanks for mentioning this! Fixed in the commit.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6ec97e588099

Comment 11

[u554753]

Verified Windows 10 64bit, Mac OS X 10.13, Ubuntu 16.04 64bit using Nightly 58.0a1 (64-bit) using today's build of Nightly.

Comment 12

[u554753]

Marking as Verified for 58 since 57 is marked as Wontfix.