1408209 - Open a whats new page for upgrades in the dev edition channel

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Sam Foster [:sfoster] (he/him)]

Bug 1399849 details a need for a dev-edition-specific what's new experience for users upgrading their dev edition firefox to 57+. When the milestone has changed, we should launch with a tab open to https://www.mozilla.org/%LOCALE%/firefox/%VERSION%a2/whatsnew/

Comment 1

[Sam Foster [:sfoster] (he/him)]

This should mostly be covered by populating the startup.homepage_override_url pref with the "what's new" URL: http://searchfox.org/mozilla-central/source/browser/branding/aurora/pref/firefox-branding.js#7

There is an open question in Bug 1399849 however as we are already mid-cycle for 57 beta & dev edition. Any new 57 beta releases will not open the whats new content for users already on 57. To show this what's new page mid-cycle (if that's is truly necessary) we would need some new logic and probably a new pref in the nsBrowserContentHandler.js: http://searchfox.org/mozilla-central/source/browser/components/nsBrowserContentHandler.js#102

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1408209 - open a whats new page in devedition (aurora branding) when version bumps.

Review commit: https://reviewboard.mozilla.org/r/189322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189322/

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: whatsnew-devedition.png screencap.

I tested the patch by creating a profile in 56, then building something like devedition using config with ac_add_options --with-branding=browser/branding/aurora, which AIUI should be the right stuff. 

The patch does not address the question of showing a what's new mid-cycle, in-between version bumps. So we can expect this to work (once uplifted) for users upgrading from 56, and thereafter.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8918475 [details]
Bug 1408209 - open a whats new page in devedition (aurora branding) when version bumps.

https://reviewboard.mozilla.org/r/189322/#review195180

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8918475 [details]
Bug 1408209 - open a whats new page in devedition (aurora branding) when version bumps.

https://reviewboard.mozilla.org/r/189322/#review195182

Given the large change in user interface between 56 and 57, I think it would be confusing to show a whatsnew page midcycle to users who have already been upgraded as it would have been obvious to them by now that Firefox has changed. Showing a whatsnew page midcycle for users that have already upgraded may give the impression that Firefox updated *again* when in fact we were just late showing the whatsnew page.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/888ec0edab2f
open a whats new page in devedition (aurora branding) when version bumps. r=jaws

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Sam Foster [:sfoster] from comment #3)

> The patch does not address the question of showing a what's new mid-cycle,
> in-between version bumps. So we can expect this to work (once uplifted) for
> users upgrading from 56, and thereafter.

As devedition is at 57 already, it probably makes sense for this to just ride the trains. Uplifting would have no value or effect. As nightly becomes 59 and devedition 58, those devedition users will see the what's new page when are upgraded.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/888ec0edab2f