1408224 - Avoid confusing errors in automation logs when failing to purge toolchain cache

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1408224 - Avoid confusing errors in automation logs when failing to purge toolchain cache.

For some reason, Windows builders are setup in a way that prevents a
task from purging the toolchain cache of old files. Until that is
figured out and fixed, all the error message related to that achieves is
confuse people because the treeherder Failure Classification tab shows
them first. Practically speaking, the error doesn't prevent anything
from working properly. The worst that can happen is disk space running
out because of the toolchain cache being filled up, which would lead to
actual errors.

As the error happens on very many windows build, that leads to a lot of
errors being bucketed on bug 1391811, while they may well be varying
unrelated issues.

It also leads to people thinking their try builds fail because of that,
when they aren't (e.g. bug 1408212).

Review commit: https://reviewboard.mozilla.org/r/188954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188954/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8918060 [details]
Bug 1408224 - Avoid confusing errors in automation logs when failing to purge toolchain cache.

https://reviewboard.mozilla.org/r/188954/#review194520

::: commit-message-25aad:8
(Diff revision 1)
> +For some reason, Windows builders are setup in a way that prevents a
> +task from purging the toolchain cache of old files. Until that is
> +figured out and fixed, all the error message related to that achieves is
> +confuse people because the treeherder Failure Classification tab shows
> +them first. Practically speaking, the error doesn't prevent anything
> +from working properly. The worst that can happen is disk space running

How realistic is this concern? If you think it is possible, we should probably still display *some* message in the exception handler so there is evidence in the log that things aren't being removed properly. It can be manually worded to avoid triggering the log handler to misidentify the bug.

Comment 3

[Mike Hommey [:glandium]]

> How realistic is this concern?

Practically speaking, it hasn't happened so far, and not all builds have those error messages. I guess builders are recycled faster than they would eat their diskspace.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9020d7696a9
Avoid confusing errors in automation logs when failing to purge toolchain cache. r=mshal

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f9020d7696a9