Closed Bug 1408279 Opened 7 years ago Closed 7 years ago

Make profile JSON easier to read

Categories

(Core :: Gecko Profiler, enhancement)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(2 files)

Make profile JSON easier to read
9.73 KB, patch
mstange
: review+
Details | Diff | Splinter Review
y
191.88 KB, text/plain
Details 
Currently the choices of SingleLineStyle and MultiLineStyle are sub-optimal,
which makes debugging of profiles difficult.

- A large chunk of the profile is put on a single line, which is very hard to
  read in a text editor.

- Other short and repetitive constructs are unnecessarily spread across
  multiple lines.

This patch makes things more readable.

        Attachment #8918136 -
        Flags: review?(mstange)

    
    

    
  

      
      
      
      

        Attached file
          
        y
        — 
      

    


  
Here's an example profile.

        Attachment #8918136 -
        Flags: review?(mstange) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/166b15223dd5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: