1408318 - The highlight hover is not centered on close button

Status: ASSIGNED

(Shield :: Shield Study, defect)

Description

[roxleitan]

Attachment: x button.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID:20171013042429

[Affected versions]:
Firefox Beta 57.0b8

[Affected platforms]:
Windows 10 x64, Ubuntu 16.04 x64, Mac OS X 10.12

[Steps to reproduce]:
1.Launch Beta 57.0b8 with a new profile
2.Install 57-perception-shield-study(attached)
3.Hover over "x" button

[Expected result]:
The highlight hover should be centered on close button

[Actual result]:
The highlight hover is not centered on close button (see the attached screenshot)

Comment 1

[roxleitan]

Attachment: [e-mail]

Comment 2

[roxleitan]

Also, on Ubuntu 16.04 x64  and Mac 10.12, when navigating through buttons using "Tab" key, the focus ring is not displayed on "x" button.

Comment 3

[Andy McKay]

This looks like a bug in the shield code rather than add-ons manager, I think.

Comment 4

[Michael Cooper [:mythmon]]

This is a problem with a particular Shield Study, not the general Shield add-on.

Gregg, this is your study add-on, right? I signed it in bug 1408103, but I can't find any other bugs relating to it. Is there a general bug for this study?

Comment 5

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Attachment: Screen Shot 2017-10-16 at 1.39.57 PM.png

Showing "embiggened" x close button.

Comment 6

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Claim:

1.  Wontfix here is fine.  (nit, not blocker)
2.  Matt_G, if you like the other thing better, we roll 1.0.2 and move on.

Comment 7

[Matt Grimes [:Matt_G]]

I think the screenshot above. I think it  makes sense to roll with 1.0.2

Comment 8

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

(blocks: https://bugzilla.mozilla.org/show_bug.cgi?id=1406537

Comment 9

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

fixed in https://github.com/gregglind/57-perception-shield-study/pull/14

Creating 1.0.2

Comment 10

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

See:  https://bugzilla.mozilla.org/attachment.cgi?id=8919029

Should be fixed now.

Comment 11

[roxleitan]

Tested on Firefox Beta 57.0b8 on Windows 10 x64, Ubuntu 16.04 and Mac OS X 10.12 with 57-perception-shield-study 1.0.2 provided in comment 10 and the highlight hover is centered on the close button now.(fixed)

But the issue from comment 2, when navigating through buttons using "Tab" key, the focus ring is not displayed on "x" button is still reproducible on Ubuntu and Mac.
On Windows, the focus ring is displayed but not centered on "x" button.