Closed Bug 1408324 Opened 7 years ago Closed 7 years ago

Port bug 1405311 to TB/Calendar: Remove :-moz-system-metric pseudo-class, replace with system metric media queries

Categories

(Thunderbird :: Theme, enhancement)

Product:
Thunderbird
Component:
Theme
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files)

TB part
2.63 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
calendar part
6.60 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
Bug1408324-missed.patch
1.10 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
Bug 1405311 removed the :-moz-system-metric pseudo-class. This gives now a lot of errors in the console and this styles don't apply correctly.
Attached patch TB part — — Splinter Review 
Simply change from system metric to media query.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8918198 - Flags: review?(jorgk)
Attached patch calendar part — — Splinter Review 
I also fixed the indentations to 4 spaces in the touched files.
Attachment #8918200 - Flags: review?(philipp)
Comment on attachment 8918200 [details] [diff] [review]
calendar part

Review of attachment 8918200 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me, thanks for the fix!
Attachment #8918200 - Flags: review?(philipp) → review+
Comment on attachment 8918198 [details] [diff] [review]
TB part

Thanks, landing this now.
Attachment #8918198 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5d07933a322a
Port bug 1405311 to TB: Remove :-moz-system-metric pseudo-class, replace with system metric media queries. r=jorgk
https://hg.mozilla.org/comm-central/rev/aea59e5a0bc8
Port bug 1405311 to Calendar: Remove :-moz-system-metric pseudo-class, replace with system metric media queries. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
Missed one in mail/themes/windows/mail/messageIcons.css.

Thanks frg
Attachment #8918626 - Flags: review?(jorgk)
Comment on attachment 8918626 [details] [diff] [review]
Bug1408324-missed.patch

Landing now (with Rust fix).
Attachment #8918626 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9890edc9e3b9
Follow-up: Missed one -moz-system-metric to replace with a media query. r=jorgk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: