1408356 - error: ‘NativeABIPrologueClobberable’ was not declared in this scope

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Dan Horák]

Looks like https://hg.mozilla.org/mozilla-central/rev/46af8801735f broke builds without JIT (seen on Fedora ppc64, ppc64le, s390x)

The builds fail with
...
/usr/bin/g++ -std=gnu++11 -o Unified_cpp_js_src38.o -c -I/home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/obj-powerpc64-unknown-linux-gnu/dist/system_wrappers -include /home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DENABLE_BINARYDATA -DENABLE_SIMD -DENABLE_WASM_THREAD_OPS -DJS_CACHEIR_SPEW -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES '-DDLL_PREFIX="lib"' '-DDLL_SUFFIX=".so"' -DMOZ_HAS_MOZGLUE -I/home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/js/src -I/home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/obj-powerpc64-unknown-linux-gnu/js/src -I/home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/obj-powerpc64-unknown-linux-gnu/dist/include -I/home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/obj-powerpc64-unknown-linux-gnu/dist/include/nspr  -fPIC  -DMOZILLA_CLIENT -include /home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/obj-powerpc64-unknown-linux-gnu/js/src/js-confdefs.h -MD -MP -MF .deps/Unified_cpp_js_src38.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wc++1z-compat -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -freorder-blocks -O3 -fno-omit-frame-pointer   -Wno-shadow -Werror=format -fno-strict-aliasing   /home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/obj-powerpc64-unknown-linux-gnu/js/src/Unified_cpp_js_src38.cpp
In file included from /home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/obj-powerpc64-unknown-linux-gnu/js/src/Unified_cpp_js_src38.cpp:20:0:
/home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/js/src/wasm/WasmFrameIter.cpp: In function ‘void GenerateCallablePrologue(js::jit::MacroAssembler&, unsigned int, js::wasm::ExitReason, uint32_t*, uint32_t*, js::wasm::CompileMode, uint32_t)’:
/home/jenkins/workspace/Firefox-default/label/ppc64/firefox-src/js/src/wasm/WasmFrameIter.cpp:391:25: error: ‘NativeABIPrologueClobberable’ was not declared in this scope
         SetExitFP(masm, NativeABIPrologueClobberable);
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: fix.patch

Thanks for the report!

Comment 2

[Dan Horák]

thanks, it fixes the problem

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 8918261 [details] [diff] [review]
fix.patch

Review of attachment 8918261 [details] [diff] [review]:
-----------------------------------------------------------------

Oops; I always forget none builds, sorry!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41e3ae0e04b1
Add missing NativeABIPrologueClobberable in none builds; r=luke

Comment 5

[Dan Horák]

(In reply to Luke Wagner [:luke] from comment #3)
> Comment on attachment 8918261 [details] [diff] [review]
> fix.patch
> 
> Review of attachment 8918261 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Oops; I always forget none builds, sorry!

no problem, we run rebuilds of trunk daily for all these arches used in Fedora, so we should be able to report (or sometimes fix) such issues early

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/41e3ae0e04b1