Remove the tabbrowser-tabs class

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: aruna.maurya12, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
Firefox 58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment)

Assignee

Comment 1

2 years ago
Hey!!Can I work on this?
Reporter

Comment 2

2 years ago
Sure!
Assignee: nobody → aruna.maurya12
Status: NEW → ASSIGNED
Assignee

Comment 3

2 years ago
Could you elaborate a bit?
Reporter

Comment 4

2 years ago
Do you have a copy of the code base? Have you built Firefox yet?

You need to remove class="tabbrowser-tabs" in browser/base/content/browser.xul and replace .tabbrowser-tabs with #tabbrowser-tabs everywhere. See also the links in comment 0.
Assignee

Comment 5

2 years ago
Yes, I have built the source code for Firefox.
Assignee

Comment 6

2 years ago
There's one more thing that I wanted to ask, I did my first bug and it is currently under review. It hasn't been merged.I had used Mercurial Queues to submit the first patch. My query is how can I do this when my patch is still under review.
Reporter

Comment 7

2 years ago
There are several ways to do this. For instance, you could remove your old commits with hg strip:

https://www.mercurial-scm.org/wiki/StripExtension

You would later have to re-import them in order to work with them again.
Assignee

Comment 8

2 years ago
Can I do it using Git?
Reporter

Comment 9

2 years ago
Yes, there's a Git mirror for mozilla-central: https://github.com/mozilla/gecko-dev
Assignee

Comment 10

2 years ago
If I am using Git to do it, I need to make a pull request? right? I need not attach any attachments here?
Reporter

Comment 11

2 years ago
No, the Git mirror is read-only. Please export the patch from git and attach it here.
Assignee

Comment 12

2 years ago
But still I can make the changes, commit and then export the patch.? right?
Reporter

Comment 13

2 years ago
Correct :)
Assignee

Comment 14

2 years ago
Hey!! The Git mirror repositery is failing to clone. Is it a possibility of resolving it without cloning it.
Reporter

Comment 15

2 years ago
No, I don't think so. How does it fail?
Assignee

Comment 16

2 years ago
Reporter

Comment 17

2 years ago
Comment on attachment 8918811 [details] [diff] [review]
Bug-1408362.patch

Looks good. Thanks!
Attachment #8918811 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/613d38c5f98c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.