1408379 - Hang during shutdown of upgrade and final crash [@ AddThreatSourceFromRedirectEntry ]

Status: RESOLVED INCOMPLETE

(Toolkit :: Safe Browsing, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I tried to update Firefox 58.0a1 from the build 20170929 to 20171012. During shutdown it hang for about 120s and finally got killed.

Here the crash details: bp-0fcb13ed-3bab-4cf3-a59d-50ff80171012

MOZ_CRASH Reason 	MOZ_CRASH(Shutdown too long, probably frozen, causing a crash.)
Crash Reason 	EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Crash Address 	0x0

0 	XUL 	AddThreatSourceFromRedirectEntry(mozilla::safebrowsing::ThreatHit&, nsIRedirectHistoryEntry*, mozilla::safebrowsing::ThreatHit_ThreatSourceType) 	toolkit/components/url-classifier/nsUrlClassifierUtils.cpp:560
1 	libnss3.dylib 	_pt_thread_death_internal 	nsprpub/pr/src/pthreads/ptthread.c:882
2 	libsystem_pthread.dylib 	_pthread_body 	
3 	libsystem_pthread.dylib 	_pthread_start 	
4 	libsystem_pthread.dylib 	thread_start 	
5 	libnss3.dylib 	PR_JoinThread 	nsprpub/pr/src/pthreads/ptthread.c:613

I already had a similar hang during shutdown end of September which is covered by that crash report: bp-f9380563-e648-4b46-8335-96ab90170927.

I'm not sure if the stack trace above really covers the underlying issue, of if that is just the look of the stack at this moment.

Comment 1

[François Marier [:francois]]

If this is in fact crashing in the ThreatHit code, then 57 is not affected.

Thomas, would you have time to have a quick look into this?

Comment 2

[Thomas Nguyen (:tnguyen)]

At the moment, I could not say whether the root cause of the crash is ThreatHit code or not. We only have 1 crash report.

0 	XUL 	AddThreatSourceFromRedirectEntry(mozilla::safebrowsing::ThreatHit&, nsIRedirectHistoryEntry*, mozilla::safebrowsing::ThreatHit_ThreatSourceType) 	toolkit/components/url-classifier/nsUrlClassifierUtils.cpp:560
1 	libnss3.dylib 	_pt_thread_death_internal 	nsprpub/pr/src/pthreads/ptthread.c:882

You will see that there's no previous frame that lead to AddThreatSourceFromRedirectEntry. In fact, that is _pt_thread_death_internal. Somehow FF hung for 2 mins and was killed (that probably is the real problem).

Comment 3

[François Marier [:francois]]

(In reply to Thomas Nguyen[:tnguyen] ni? plz from comment #2)
> You will see that there's no previous frame that lead to
> AddThreatSourceFromRedirectEntry. In fact, that is
> _pt_thread_death_internal. Somehow FF hung for 2 mins and was killed (that
> probably is the real problem).

Thanks for double-checking Thomas.

Let's wait to see if it happens again.

Comment 4

[François Marier [:francois]]

This has only occurred once in the last 3 months: https://crash-stats.mozilla.com/signature/?signature=AddThreatSourceFromRedirectEntry&date=%3E%3D2017-08-14T03%3A48%3A44.000Z&date=%3C2017-11-14T03%3A48%3A44.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1