when running devtools on a mulitcore machine in linux64-asan we get failure to allocate and leaks

RESOLVED FIXED in Firefox 58

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: jmaher, Unassigned)

Tracking

53 Branch
Firefox 58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a month ago
I am trying to remove the use of our single core m1.medium test machines and devtools on linux64-asan is one of the last 2 suites remaining.

here is a try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8545b82c78b04af34da0e6d895b48153584a3cc&selectedJob=136783279&filter-searchStr=dt7

you can see out of 20+ jobs that ran, 3 fails in dt7 for failure to allocate and leaks.

I really don't know much about ASAN and how to debug this, I do see these errors showing up at the end of the netmonitor test suite.
(Reporter)

Comment 1

a month ago
sorry, these are not the netmonitor ones, those are tracked in bug 1408384, these all seem to fail right after the webconsole tests complete.
This view source test is running the same assertions twice, one for the new debugger and one for the old. Maybe that's why it is timing out - we don't need to run it any more in the old debugger config so I can make a patch to test that out
Priority: -- → P3
Comment hidden (mozreview-request)
Joel, I'm not sure if you had to do something special to make sure the tests were running on the new hardware. I've attached a patch - can you check and see if it fixes the leak?
Flags: needinfo?(jmaher)
(Reporter)

Comment 5

a month ago
mozreview-review
Comment on attachment 8920261 [details]
Bug 1408387 - Only run browser_webconsole_view_source.js task in the new debugger

https://reviewboard.mozilla.org/r/191274/#review196478

this is probably good to do even if it doesn't fix the problem.

I have a try push going:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3a2feca2663d7657bf89c5488405db2a2d90f19

should have results in 1-2 hours.
Attachment #8920261 - Flags: review?(jmaher) → review+
(Reporter)

Comment 6

a month ago
my try run is looking good- not sure if it is running, but no perma or high frequency failures :)
Flags: needinfo?(jmaher)

Comment 7

a month ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f18391c3d420
Only run browser_webconsole_view_source.js task in the new debugger r=jmaher
https://hg.mozilla.org/mozilla-central/rev/f18391c3d420
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.