Remove toolkit.telemetry.enabled preference element from preferences/in-content/main.xul

RESOLVED FIXED in Firefox 58

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: chutten, Assigned: joshualonghi, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [good first bug][lang=xul])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The <preference> xul element in browser/components/preferences/in-content/main.xul is unnecessary and should be removed.

This is just a straightforward removal of four lines from that file.
(Assignee)

Comment 1

a year ago
(In reply to Chris H-C :chutten from comment #0)
> The <preference> xul element in
> browser/components/preferences/in-content/main.xul is unnecessary and should
> be removed.
> 
> This is just a straightforward removal of four lines from that file.

Hi Chris, I'd like to take on this bug if possible! Thanks.
(Reporter)

Comment 2

a year ago
Please by all means do so! Let me know if you have any questions.
Assignee: nobody → joshualonghi
Status: NEW → ASSIGNED
(Reporter)

Comment 4

a year ago
Comment on attachment 8919063 [details] [diff] [review]
Removed toolkit.enabled preference element

Review of attachment 8919063 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Next time be sure to set the review flag to "?" and chose a reviewer to be notified that they should take a look. (For bugs like these with a Mentor set, the Mentor's a good person to r?) This does a couple things internally in bugzilla including putting a red number at the top of every one of the reviewer's bugzilla pages until they get around to it so it doesn't get missed :)
Attachment #8919063 - Flags: review+
(Reporter)

Comment 5

a year ago
I have flagged this for checkin. Given the timing this should be in one of tomorrow's Firefox Nightly builds. Thank you for your contribution!

Would you like any help finding more bugs to fix?
Keywords: checkin-needed
(Assignee)

Comment 6

a year ago
Thanks for the advice Chris, sure I would love to work on some more bugs!

Comment 7

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26e7993bfbfa
Remove toolkit.telemetry.enabled preference element. r=chutten
Keywords: checkin-needed
(Reporter)

Comment 8

a year ago
Well, if you'd like more of the same there are some more "just remove this code" bugs in bug 1408512 and bug 1408429 and other ones in the "Depends on" list of bug 1406390.

If you'd prefer something with more substance, here's a query looking for the tag "[good next bug]" and here's one for "[good second bug]"

There are plenty of choices in plenty of languages, like bug 1401612 which requires a little Python know-how and bug 1408429 which is just a bit of Javascript clean-up.

[1]: https://bugzilla.mozilla.org/buglist.cgi?list_id=13834971&resolution=---&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=%5Bgood%20next%20bug%5D
[2]: https://bugzilla.mozilla.org/buglist.cgi?list_id=13834973&resolution=---&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=%5Bgood%20second%20bug%5D
(Assignee)

Comment 9

a year ago
(In reply to Chris H-C :chutten from comment #8)
> Well, if you'd like more of the same there are some more "just remove this
> code" bugs in bug 1408512 and bug 1408429 and other ones in the "Depends on"
> list of bug 1406390.
> 
> If you'd prefer something with more substance, here's a query looking for
> the tag "[good next bug]" and here's one for "[good second bug]"
> 
> There are plenty of choices in plenty of languages, like bug 1401612 which
> requires a little Python know-how and bug 1408429 which is just a bit of
> Javascript clean-up.
> 
> [1]:
> https://bugzilla.mozilla.org/buglist.cgi?list_id=13834971&resolution=---
> &status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboar
> d=%5Bgood%20next%20bug%5D
> [2]:
> https://bugzilla.mozilla.org/buglist.cgi?list_id=13834973&resolution=---
> &status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboar
> d=%5Bgood%20second%20bug%5D

I'll have a look through them. Thanks again for the guidance and help.
https://hg.mozilla.org/mozilla-central/rev/26e7993bfbfa
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.