1408428 - Remove toolkit.telemetry.enabled preference element from preferences/in-content/main.xul

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P3)

Description

[Chris H-C :chutten]

The <preference> xul element in browser/components/preferences/in-content/main.xul is unnecessary and should be removed.

This is just a straightforward removal of four lines from that file.

Comment 1

[Joshua Longhi]

(In reply to Chris H-C :chutten from comment #0)
> The <preference> xul element in
> browser/components/preferences/in-content/main.xul is unnecessary and should
> be removed.
> 
> This is just a straightforward removal of four lines from that file.

Hi Chris, I'd like to take on this bug if possible! Thanks.

Comment 2

[Chris H-C :chutten]

Please by all means do so! Let me know if you have any questions.

Comment 3

[Joshua Longhi]

Attachment: Removed toolkit.enabled preference element

Comment 4

[Chris H-C :chutten]

Comment on attachment 8919063 [details] [diff] [review]
Removed toolkit.enabled preference element

Review of attachment 8919063 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Next time be sure to set the review flag to "?" and chose a reviewer to be notified that they should take a look. (For bugs like these with a Mentor set, the Mentor's a good person to r?) This does a couple things internally in bugzilla including putting a red number at the top of every one of the reviewer's bugzilla pages until they get around to it so it doesn't get missed :)

Comment 5

[Chris H-C :chutten]

I have flagged this for checkin. Given the timing this should be in one of tomorrow's Firefox Nightly builds. Thank you for your contribution!

Would you like any help finding more bugs to fix?

Comment 6

[Joshua Longhi]

Thanks for the advice Chris, sure I would love to work on some more bugs!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26e7993bfbfa
Remove toolkit.telemetry.enabled preference element. r=chutten

Comment 8

[Chris H-C :chutten]

Well, if you'd like more of the same there are some more "just remove this code" bugs in bug 1408512 and bug 1408429 and other ones in the "Depends on" list of bug 1406390.

If you'd prefer something with more substance, here's a query looking for the tag "[good next bug]" and here's one for "[good second bug]"

There are plenty of choices in plenty of languages, like bug 1401612 which requires a little Python know-how and bug 1408429 which is just a bit of Javascript clean-up.

[1]: https://bugzilla.mozilla.org/buglist.cgi?list_id=13834971&resolution=---&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=%5Bgood%20next%20bug%5D
[2]: https://bugzilla.mozilla.org/buglist.cgi?list_id=13834973&resolution=---&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=%5Bgood%20second%20bug%5D

Comment 9

[Joshua Longhi]

(In reply to Chris H-C :chutten from comment #8)
> Well, if you'd like more of the same there are some more "just remove this
> code" bugs in bug 1408512 and bug 1408429 and other ones in the "Depends on"
> list of bug 1406390.
> 
> If you'd prefer something with more substance, here's a query looking for
> the tag "[good next bug]" and here's one for "[good second bug]"
> 
> There are plenty of choices in plenty of languages, like bug 1401612 which
> requires a little Python know-how and bug 1408429 which is just a bit of
> Javascript clean-up.
> 
> [1]:
> https://bugzilla.mozilla.org/buglist.cgi?list_id=13834971&resolution=---
> &status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboar
> d=%5Bgood%20next%20bug%5D
> [2]:
> https://bugzilla.mozilla.org/buglist.cgi?list_id=13834973&resolution=---
> &status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboar
> d=%5Bgood%20second%20bug%5D

I'll have a look through them. Thanks again for the guidance and help.

Comment 10

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/26e7993bfbfa