1408482 - dom/html/HTMLMediaElement.cpp:4883:5: error: 'SprintfLiteral' was not declared in this scope

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jan Beich]

On Tier3 platforms without GeckoProfiler (iOS, Linux non-x86, BSDs, Solaris) the build is broken because "GeckoProfiler.h" doesn't bootleg "mozilla/Sprintf.h". To reproduce on Tier1 platforms before bug 1371159 is fixed one has to force `return None` in gecko_profiler()[2].

In file included from objdir/dom/html/Unified_cpp_dom_html2.cpp:11:
dom/html/HTMLMediaElement.cpp:4883:5: error: use of undeclared identifier
      'SprintfLiteral'
    SprintfLiteral(buf,
    ^
1 error generated.

In file included from objdir/dom/html/Unified_cpp_dom_html2.cpp:2:
In file included from dom/html/HTMLMapElement.cpp:7:
In file included from objdir/dist/include/mozilla/dom/HTMLMapElement.h:11:
In file included from dom/html/nsGenericHTMLElement.h:11:
In file included from dom/base/nsMappedAttributeElement.h:16:
In file included from objdir/dist/include/mozilla/GenericSpecifiedValues.h:19:
In file included from objdir/dist/include/nsPresContext.h:41:
In file included from objdir/dist/include/ScrollbarStyles.h:12:
In file included from objdir/dist/include/mozilla/dom/WindowBinding.h:14:
In file included from objdir/dist/include/mozilla/dom/ToJSValue.h:12:
In file included from objdir/dist/include/mozilla/dom/BindingUtils.h:35:
In file included from dom/base/nsJSUtils.h:19:
In file included from objdir/dist/include/GeckoProfiler.h:60:
objdir/dist/include/mozilla/Sprintf.h:12:2: error: bootlegging test

[1] http://searchfox.org/mozilla-central/rev/ed1d5223adcd/tools/profiler/public/GeckoProfiler.h#62
[2] http://searchfox.org/mozilla-central/rev/ed1d5223adcd/toolkit/moz.configure#26

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1408482 - fix build error.

Review commit: https://reviewboard.mozilla.org/r/190032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190032/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8919117 [details]
Bug 1408482 - fix build error.

https://reviewboard.mozilla.org/r/190032/#review195226

Comment 3

[Jan Beich]

Comment on attachment 8919117 [details]
Bug 1408482 - fix build error.

I confirm this fixes FreeBSD build.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e0104c1ce80
fix build error. r=gerald

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3e0104c1ce80