Closed Bug 1408508 Opened 2 years ago Closed 2 years ago

Move Context.{CONTENT,CHROME} to testing/marionette/browser.js

Categories

(Testing :: Marionette, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

User Story

Please follow the guide in how to get started:
https://wiki.mozilla.org/User:Mjzffr/New_Contributors

Attachments

(1 file)

To avoid circular imports and clean up our dependency hierarchy,
Context.{CONTENT,CHROME} should probably be defined in
testing/marionette/browser.js which deals with browsing contexts.

As part of this work, remember to update any references to "content"
and "chrome" elsewhere in the codebase.
Mentor: ato
User Story: (updated)
Keywords: good-first-bug
Whiteboard: [lang=js]
Assignee: nobody → ato
Status: NEW → ASSIGNED
Mentor: ato
Keywords: good-first-bug
Whiteboard: [lang=js]
Comment on attachment 8918926 [details]
Bug 1408508 - Move Context to browser module.

https://reviewboard.mozilla.org/r/189828/#review195306

::: commit-message-c6a26:5
(Diff revision 1)
> +Bug 1408508 - Move Context to browser module. r?maja_zf
> +
> +To avoid circular dependencies in Marionette, specific types
> +or symbols required by many parts of Marionette should live in
> +namespaced modules so that they can be imported without fear or recursion.

s/or/of/

::: commit-message-c6a26:7
(Diff revision 1)
> +For example, if testing/marionette/browser.js which in the
> +future needs to have access to the Context enum were to import

s/which in the future//

::: commit-message-c6a26:9
(Diff revision 1)
> +or symbols required by many parts of Marionette should live in
> +namespaced modules so that they can be imported without fear or recursion.
> +
> +For example, if testing/marionette/browser.js which in the
> +future needs to have access to the Context enum were to import
> +testing/marionette/driver.js where it is specified, Cu.import would

s/where it is specified//
Comment on attachment 8918926 [details]
Bug 1408508 - Move Context to browser module.

https://reviewboard.mozilla.org/r/189828/#review195588
Attachment #8918926 - Flags: review?(mjzffr) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2024bea0c299 -d 4e79dee55e25: rebasing 427177:2024bea0c299 "Bug 1408508 - Move Context to browser module. r=maja_zf" (tip)
merging testing/marionette/browser.js
merging testing/marionette/driver.js
warning: conflicts while merging testing/marionette/driver.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/286a5ba56cec
Move Context to browser module. r=maja_zf
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9b6e1e83c71
Move Context to browser module. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/a9b6e1e83c71
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.