1408539 - Onboarding Tour: update customize, library, and screenshot illustration

Status: VERIFIED FIXED

(Firefox :: Tours, defect, P3)

Description

[Jennifer Davidson (she/her) [:jdavidson]]

Attachment: onboarding tour customize - with pocket icon.png

As per the following description on a different bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1399142#c0

Remove the Pocket icon from the Customize illustration in the Onboarding Tour because Pocket cannot be customized. 

Attached is the original Customize panel in the Onboarding Tour overlay.

Comment 1

[[e-mail]]

Smartell could you help on provide new illustration?

Comment 2

[Sean Martell]

Attachment: customize.svg

Fixed

Comment 3

[[e-mail]]

I saw you update library & screenshot svg in bug 1399142, do you think we need those 2 changes as well in v57?
We can update these 3 illustrations at once in this bug.

Comment 4

[[e-mail]]

verdi/bryant I need your help to provide these 3 svg in right default size & tune for the optimize size through  https://jakearchibald.github.io/svgomg/

Comment 5

[Bryant Mao [:bryantmao]]

Fred, to be confirmed, are you referring to the library, screenshot, and customized illustration? And do you want us to adjust the frame size to 352x303 and under 80kb?

Comment 6

[[e-mail]]

Yes, please

Comment 7

[Bryant Mao [:bryantmao]]

Attachment: customize_library_screenshot_svg (compressed).zip

SVG attached, see if that works.

Comment 8

[Nicole Yee (:nicoleyee)]

via email:
"We can update 3 illustration updates in bug 1408539 at once, without re-uplift bug 1399142"

Hi Fred,
If we plan on taking this course of action, can you please update the bug name so it clearly depicts that we are updating all 3 illustrations and not just the customize illustration.

Comment 9

[[e-mail]]

Hi Bryant, the compressed files size are still too large (200k, 106k) compare to the existing one (~70k).
I can't see the big difference between old and new one so they might able to compress to the same level file size, 
can you help double check if we can compress them more?

Comment 10

[Bryant Mao [:bryantmao]]

Attachment: customize_library_screenshot_svg_1027(compressed).zip

Hey Fred, I've tried the compression again, see the latest attachment. So far, the customize SVG is still around 100k, not sure if that work for you. 

If not, we might need to ask Sean to check the illustration again to see if there are redundant layers that can be removed (the current layer number is twice as much than the original one, even the pocket icon removed)

Comment 11

[[e-mail]]

Attachment: Bug 1408539 - Onboarding Tour: update customize, library, and screenshot illustration;

Review commit: https://reviewboard.mozilla.org/r/193818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193818/

Comment 12

[[e-mail]]

Thanks, the patch comes with 3 updated illustrations

Comment 13

[Bryant Mao [:bryantmao]]

(In reply to Bryant Mao [:bryantmao] from comment #10)
> Created attachment 8922607 [details]
> customize_library_screenshot_svg_1027(compressed).zip
> 
> Hey Fred, I've tried the compression again, see the latest attachment. So
> far, the customize SVG is still around 100k, not sure if that work for you. 
> 
> If not, we might need to ask Sean to check the illustration again to see if
> there are redundant layers that can be removed (the current layer number is
> twice as much than the original one, even the pocket icon removed

Hi Sean, can you possibly check if you can still make the size of the Customize SVG smaller? It will help the tour load faster.

Comment 14

[Fischer [:Fischer]]

Comment on attachment 8922679 [details]
Bug 1408539 - Onboarding Tour: update customize, library, and screenshot illustration;

https://reviewboard.mozilla.org/r/193818/#review198976

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b78af3ab388
Onboarding Tour: update customize, library, and screenshot illustration;r=Fischer

Comment 16

[[e-mail]]

The images look good and already in the reasonable size. I think we shouldn't be blocked by waiting more days for further downsize images when we want to present these images in v57.

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7b78af3ab388

Comment 18

[[e-mail]]

Comment on attachment 8922679 [details]
Bug 1408539 - Onboarding Tour: update customize, library, and screenshot illustration;

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: img shows pocket icon in customize tour but it can't be customized, the rest 2 modification are based on research feedback
[Is this code covered by automated tests?]: N
[Has the fix been verified in Nightly?]: N, manual checked images are updated 
[Needs manual test from QE? If yes, steps to reproduce]: open onboarding and check all tours. go to about:config to change pref "browser.onboarding.tour-type" from `new` to `update`, refresh and wait several seconds to check update user tour sets.
[List of other uplifts needed for the feature/fix]: N
[Is the change risky?]: N
[Why is the change risky/not risky?]: image update only
[String changes made/needed]: N

Comment 19

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8922679 [details]
Bug 1408539 - Onboarding Tour: update customize, library, and screenshot illustration;

Low risk, Onboarding Tour related, Beta57+

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3e4524e4b179

Comment 21

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 58.0a1, build ID: 20171013220204, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 58.0a1, build ID: 20171102100041, and Fx 57.0b14, on Windows 10 x64, Ubuntu 14.04 LTS and mac OS X 10.13.