1408568 - SandboxReport::ProcType::FILE needs a case in SandboxReportWrapper::GetProcType

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Bug 1308400 added a variant to SandboxReport::ProcType for file processes, but it's not mapped to a string in SandboxReportWrapper::GetProcType.  This will throw a JS exception on release builds, and crash with an assertion failure on debug builds, if there's a rejected syscall in a file content process and about:support / Troubleshoot.jsm is then used.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

This touches l10n strings, which could be a problem for uplift.  One alternative is to map SandboxReport::ProcType::FILE to "content" (same as SandboxReport::ProcType::CONTENT), uplift that, and then land a second patch on m-c which gives it its own string.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

On non-debug builds, this will replace the entire "sandbox" branch of the Troubleshoot.jsm data with an error message, which in turn causes the formatter in about:support to throw an exception.  Fortunately, "sandbox" is still the last one in the list, so bug 1374327 won't result in collateral damage to other parts of about:support in this case.  (I tested this on a debug build with the assertion removed.)

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1408568 - Handle SandboxReport::ProcType::FILE correctly in XPCOM bindings.

Review commit: https://reviewboard.mozilla.org/r/189354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189354/

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8918491 [details]
Bug 1408568 - Handle SandboxReport::ProcType::FILE correctly in XPCOM bindings.

https://reviewboard.mozilla.org/r/189354/#review194902

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25089d5c04f4
Handle SandboxReport::ProcType::FILE correctly in XPCOM bindings. r=gcp

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/25089d5c04f4