1408572 - Remove handleCtrlPageUpDown attribute and associated code

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Brian Grinstead [:bgrins]]

I ran into this in Bug 1392352, and I can't find any place where this attribute is set: https://searchfox.org/mozilla-central/search?q=handleCtrlPageUpDown.

Comment 1

[Brian Grinstead [:bgrins]]

Dão, are there any consumers of this attribute / property that I'm missing?

Comment 2

[Brian Grinstead [:bgrins]]

on MDN: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/handleCtrlPageUpDown

Comment 3

[Dão Gottwald [:dao]]

Yeah, looks unused.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1408572 - Remove handleCtrlPageUpDown attribute and associated code;

Review commit: https://reviewboard.mozilla.org/r/191656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191656/

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8920665 [details]
Bug 1408572 - Remove handleCtrlPageUpDown attribute and associated code;

https://reviewboard.mozilla.org/r/191656/#review196994

::: toolkit/content/widgets/tabbox.xml:148
(Diff revision 1)
>                    event.preventDefault();
>                  }
>                break;
>              case event.DOM_VK_PAGE_UP:
> -              if (event.ctrlKey && !event.shiftKey && !event.altKey && !event.metaKey)
> -                if (this.tabs && this.handleCtrlPageUpDown) {
> +              if (event.ctrlKey && !event.shiftKey &&
> +                  !event.altKey && !event.metaKey && this.tabs) {

nit: I'd prefer having all event checks on one line, or each on a separate line, and the this.tabs check on the next line

::: toolkit/content/widgets/tabbox.xml:158
(Diff revision 1)
>              case event.DOM_VK_PAGE_DOWN:
> -              if (event.ctrlKey && !event.shiftKey && !event.altKey && !event.metaKey)
> -                if (this.tabs && this.handleCtrlPageUpDown) {
> +              if (event.ctrlKey && !event.shiftKey &&
> +                  !event.altKey && !event.metaKey && this.tabs) {
>                    this.tabs.advanceSelectedTab(1, true);
>                    event.preventDefault();
>                  }

Please fix up the indentation

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8920665 [details]
Bug 1408572 - Remove handleCtrlPageUpDown attribute and associated code;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191656/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e49aaf48550
Remove handleCtrlPageUpDown attribute and associated code;r=dao

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8e49aaf48550

Comment 9

[Chris Mills [:cmills]]

I've removed the page covering this attribute completely, since it is used nowhere and has been removed.