1408579 - Run eslint on calendar in taskcluster.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Comment 1

[Tom Prince [:tomprince]]

As a first step to enabling taskcluster, add a simple job that increases the coverage we get. Specifically `calendar/` has eslint configuration, but since it doesn't get run automatically, cleanups tend to bit rot.

Comment 2

[Tom Prince [:tomprince]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5f7ea919c450e9645bf9e04e4c610ca7649e3c55

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1408579: Enable eslint on taskcluster;

Review commit: https://reviewboard.mozilla.org/r/189346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189346/

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8918487 [details]
Bug 1408579: Enable eslint on taskcluster;

https://reviewboard.mozilla.org/r/189346/#review194640

I'm a little confused about how all of this works (and I apologize for not being able to keep it all in my head..)

So comm-central has its own .taskcluster.yml and its own taskcluster/ci, but uses taskcluster/taskgraph from gecko?  Or is that merged into comm-central?  Or...

::: .taskcluster.yml:21
(Diff revision 1)
> +    schedulerId: 'gecko-level-${repository.level}'
> +
> +    # FIXME: expires should be longer than 2d
> +    created: {$fromNow: ''}
> +    deadline: {$fromNow: '1 day'}
> +    expires: {$fromNow: '1 year 5 second'} # 1 second so artifacts expire first, despite rounding errors

These comments look out of date

::: .taskcluster.yml:45
(Diff revision 1)
> +      then: {createdForUser: "${ownerEmail}"}
> +
> +    routes:
> +      - "tc-treeherder.v2.${repository.project}.${push.revision}.${push.pushlog_id}"
> +      - "tc-treeherder-stage.v2.${repository.project}.${push.revision}.${push.pushlog_id}"
> +      - "index.garbage.thunderbird.latest.decision"

Let's get you a project -- maybe "comm" -- so you can have a dedicated index space.

::: taskcluster/ci/source-test/kind.yml:16
(Diff revision 1)
> +
> +jobs-from:
> +   - mozlint.yml
> +
> +# This is used by run-task based tasks to lookup which build task it
> +# should depend on based on its own platform.

I think this isn't needed here?

Comment 5

[Tom Prince [:tomprince]]

Comment on attachment 8918487 [details]
Bug 1408579: Enable eslint on taskcluster;

https://reviewboard.mozilla.org/r/189346/#review194640

You've got it correct. .taskcluster.yml and taskcluster/ci are configuration, and present in comm-central. taskcluster/taskgraph is code which is at least somehwat generic (and I've been working to make it slightly more generic in the ways that isn't generic enough) and we just use the copy in gecko.

> Let's get you a project -- maybe "comm" -- so you can have a dedicated index space.

We've got scopes for indexes under gecko et al already ([here](https://tools.taskcluster.net/auth/roles/repo:hg.mozilla.org/try-comm-central:*)). But, I don't think we need indexing for anything at the moment, so I'll just drop this for the moment, and we can have a larger discussion about index (especially since we have two axes on which we want to index) later.

> I think this isn't needed here?

Yeah. This was copied from upstream, but it probably makes sense to drop it until we need it.

Comment 6

[Tom Prince [:tomprince]]

Comment on attachment 8918487 [details]
Bug 1408579: Enable eslint on taskcluster;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189346/diff/1-2/

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8918487 [details]
Bug 1408579: Enable eslint on taskcluster;

https://reviewboard.mozilla.org/r/189346/#review195502

I'm worried about maintaining cross-repo compatibility (taskcluster/ci vs. taskcluster/taskgraph), but I bet this is a tiny fraction of the complexity that the communicator source itself faces, so probably not a big concern for you.

Comment 8

[Tom Prince [:tomprince]]

Comment on attachment 8918487 [details]
Bug 1408579: Enable eslint on taskcluster;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189346/diff/2-3/

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8918487 [details]
Bug 1408579: Enable eslint on taskcluster;

https://reviewboard.mozilla.org/r/189346/#review196292

Comment 10

[Tom Prince [:tomprince]]

Comment on attachment 8918487 [details]
Bug 1408579: Enable eslint on taskcluster;

https://reviewboard.mozilla.org/r/189346/#review195502

Yeah. And moving in this direction decreases the divergence from firefox in several regards, so should make things easier. In particular, getting off buildbot and adopting mozharness.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/195f3d2bfb40
Enable eslint on taskcluster; r=dustin,Fallen