1408637 - [Pontoon] Batch approval is broken

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect)

Description

[Tomer Cohen :tomer]

Attachment: screenshot

Steps to reproduce:
Trying to approve multiple strings at the same time.

Actual result:
An error message 'OOPS, SOMETHING WENT WRONG'

Manual approval of strings one-by-one works as expected. The problem can be reproduced in other projects as well.

Under the hood, the application fail to complete XMLHttpRequest to https://pontoon.mozilla.org/batch-edit-translations/ with HTTP Error 500 Internal Server Error. The response contains the following snippet (which sadly will never get displayed on the browser because it expect non-HTML content!) -

    <section id="error">
      <div class="inner">
        <h1 id="title"><a href="/">Oops!</a></h1>
        <h2 id="subtitle">Something is wrong. We're going to fix it soon.</h2>
      </div>
    </section>

Comment 1

[Matjaz Horvat [:mathjazz]]

This is a regression:
https://github.com/mozilla/pontoon/commit/2d6c1baa4186a9fa8687153868f62eb8cc9bb405#diff-c18ce63ddb8aca155c0553a0c1b174e3L1917

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/734

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/6dbddb87e63b8074101d31ccefa2be7cc622251c
Fix bug 1408637: EntityQuerySet.prefetch_resources_translations() is deprecated (#734)

Comment 4

[Axel Hecht [:Pike]]

Can we add tests for this feature in a sane way?

Comment 5

[Matjaz Horvat [:mathjazz]]

I was wondering about the same thing.

We should have a unit test for each QuerySet method, and that should be sufficient. Once the method is removed, the test will fail.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

I was going to say the same thing as Axel. I'm in favor of reopening this bug until we have a unit test for this test case. If you disagree, close away! :)

Comment 7

[Matjaz Horvat [:mathjazz]]

This is being tested as of https://github.com/mozilla/pontoon/commit/cc2c0af38fed56e39b4e5511c28de089b35d76bf.