Closed Bug 1408644 Opened 5 years ago Closed 5 years ago

Mismatch between ./mach artifact toolchain Proguard install location and location expected by build system

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: JanH, Unassigned)

References

Details

I ran |./mach artifact toolchain -v --from-build proguard-jar| as instructed by Nick's e-mail [1]. This has installed Proguard into my source checkout, however if I then attempt to build, the build system seems to be looking for Proguard within my .mozbuild directory and consequently cannot find anything:
> ERROR: proguard.jar 5.3.3 or higher is required (looked for /home/jan/.mozbuild/proguard/lib/proguard.jar). Run |mach artifact install --from-build proguard-jar| or add `export PROGUARD_JAR=/path/to/proguard.jar` to your mozconfig.


[1] https://mail.mozilla.org/pipermail/mobile-firefox-dev/2017-October/002341.html
Version: Firefox 57 → Trunk
gps: glandium: |mach artifact toolchain| installs into $CWD, which makes sense for automation but is a hassle for local developers.  We could improve this by adding a `--cwd` option to the mach command, and

- making the default be install into MOZBUILD_STATE_PATH, and using --cwd in automation
- keeping the existing default and using --cwd locally
- sniffing MOZ_AUTOMATION (or TASKCLUSTER_*, or ...) to determine the behaviour

I would prefer the first option, since I think that developer ergonomics beats out automation, and that automation should stop putting stuff in the topsrcdir every task (slowing down checkouts, which need to purge, and generally being awkward).  Do you have a strong opinion?
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(gps)
I'd go with the third option. There are too many places that call mach artifact toolchain for automation, it's a PITA to change them all.
Flags: needinfo?(mh+mozilla)
I'd sniff MOZ_AUTOMATION as well.

Alternatively, we could change the mozbuild state path resolution to point to somewhere under CWD or relative to topsrcdir if MOZ_AUTOMATION is set. Basically accomplishes the same thing.
Flags: needinfo?(gps)
This is no longer needed after https://bugzilla.mozilla.org/show_bug.cgi?id=1440428.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox Build System
You need to log in before you can comment on or make changes to this bug.