1408684 - Fix NoImageTests XCUITests

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Isabel Rios[:isabel_rios]]

Some change has been applied in latest commits that make this test to fail due to a compilation error and so the build is not built either. No test results on BB.

Error: 
Static member 'NoImageButtonIdentifier' cannot be used on instance of type 'NoImageTests'

Working on commit: dc9b564d80a426b72a636eb3cb6262885f3d2c60
Failing on commit: fac4e03e6103cd0b038325cb7207681e949e685d

Seems that the identifier has changed but need further investigation to find out the cause and fix the test

Comment 1

[Isabel Rios[:isabel_rios]]

As per changes in bug 1405825. 
The identifiers for Menu icons have changed. 
Now they are accesible as: app.tables["Context Menu"].cells["menu-NoImageMode"]
In this tests. There will be other tests affected by this change.

Comment 2

[Isabel Rios[:isabel_rios]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3307

Comment 3

[Isabel Rios[:isabel_rios]]

Asking for review because the tests failing (https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/59e4601fe80008000198a4cb#tests) are not related to this PR.
Two of them are due to bug 1408956
And the other due to regression bug 1408837

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8918765 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3307

LGTM, squash & commit please, thanks!

Comment 5

[Isabel Rios[:isabel_rios]]

Merged: https://github.com/mozilla-mobile/firefox-ios/commit/20ebe1792d6cd28e62c9ec3fc5742a04aaa07bf4

Comment 6

[Isabel Rios[:isabel_rios]]

Adding [needsuplift]  witheboard, we will need this fix there to be able to compile and run the tests on the Tests schemas. Thanks