1408686 - Add a maintenance task to set missing last modified date and date added for bookmarks

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement)

Description

[Lina Cambridge [:lina] (ex-Mozilla)]

Bug 1407922 has a database where a bookmark's `dateAdded` and `lastModified` are null. This will confuse Sync and the UI, so let's fix up bookmarks that don't have them.

We can try falling back to the oldest visit date from `moz_historyvisits` and the `last_visit_date` from `moz_places`, respectively, except those might *also* be null. Or we can unconditionally use the current date and time.

Comment 1

[Lina Cambridge [:lina] (ex-Mozilla)]

Attachment: Bug 1408686 - Add a maintenance task to set missing last modified date and date added for bookmarks.

For bookmarks without an added date, we'll fall back to the last
modified date, earliest visit date, and current time, in that
order. For missing last modified dates, we'll try the date added,
latest visit date, and current time.

Review commit: https://reviewboard.mozilla.org/r/189938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189938/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8919030 [details]
Bug 1408686 - Add a maintenance task to set missing last modified date and date added for bookmarks.

https://reviewboard.mozilla.org/r/189938/#review195406

::: toolkit/components/places/PlacesDBUtils.jsm:860
(Diff revision 1)
> +             WHERE place_id = fk
> +           ), :currentTime)
> +       WHERE dateAdded IS NULL OR
> +             lastModified IS NULL`,
> +      params: {
> +        currentTime: PlacesUtils.toPRTime(new Date()),

FYI, you can generate a valid PRTime in SQL using SELECT strftime("%s", "now", "localtime", "utc") * 1000
It's pretty much equivalent to "new Date() * 1000"

Comment 3

[Lina Cambridge [:lina] (ex-Mozilla)]

Comment on attachment 8919030 [details]
Bug 1408686 - Add a maintenance task to set missing last modified date and date added for bookmarks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189938/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a9f04d67bd0
Add a maintenance task to set missing last modified date and date added for bookmarks. r=mak

Comment 5

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0a9f04d67bd0