1408737 - Upgrade reselect in Devtools shared libraries

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P2)

Description

[[e-mail]]

After bug 1310573 we have reselect 2.5.4 in our shared libraries.

According to reselect release note, 3.0.0 bring performance improvement to reslect 
https://github.com/reactjs/reselect/releases

It's worth to evaluate the new version by following
http://searchfox.org/mozilla-central/source/devtools/client/shared/vendor/RESELECT_UPGRADING

Comment 1

[[e-mail]]

Local DAMP test shows 150ms(5.5k->5.4k) improvement for complicated requestsFinished test case

current

{
          "name": "simple.netmonitor.open.DAMP",
          "value": 359.5824999999968
        },
        {
          "name": "simple.netmonitor.reload.DAMP",
          "value": 57.852499999999054
        },
        {
          "name": "simple.netmonitor.requestsFinished.DAMP",
          "value": 139.63749999999982
        },
        {
          "name": "simple.netmonitor.close.DAMP",
          "value": 28.159999999999968
        },
        {
          "name": "complicated.netmonitor.open.DAMP",
          "value": 481.27750000000196
        },
        {
          "name": "complicated.netmonitor.reload.DAMP",
          "value": 1125.2949999999946
        },
        {
          "name": "complicated.netmonitor.requestsFinished.DAMP",
          "value": 5579.904999999999
        },
        {
          "name": "complicated.netmonitor.close.DAMP",
          "value": 96.34499999999753
        }
      ],
      "value": 265.8106782849597
    }
  ]
}

with new reselect lib

{
        {
          "name": "simple.netmonitor.open.DAMP",
          "value": 367.40499999999884
        },
        {
          "name": "simple.netmonitor.reload.DAMP",
          "value": 62.842499999999745
        },
        {
          "name": "simple.netmonitor.requestsFinished.DAMP",
          "value": 145.78999999999724
        },
        {
          "name": "simple.netmonitor.close.DAMP",
          "value": 28.9950000000008
        },
        {
          "name": "complicated.netmonitor.open.DAMP",
          "value": 483.9175000000014
        },
        {
          "name": "complicated.netmonitor.reload.DAMP",
          "value": 1099.3599999999988
        },
        {
          "name": "complicated.netmonitor.requestsFinished.DAMP",
          "value": 5427.237500000003
        },
        {
          "name": "complicated.netmonitor.close.DAMP",
          "value": 96.0699999999988
        }
      ],
      "value": 270.0290903956924
    }
  ]
}

Comment 2

[[e-mail]]

Attachment: Bug 1408737 - Upgrade reselect in Devtools shared libraries;

Review commit: https://reviewboard.mozilla.org/r/193702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193702/

Comment 3

[[e-mail]]

run DAMP on tree herder https://treeherder.mozilla.org/#/jobs?repo=try&revision=75d6b1e04d17

Comment 4

[[e-mail]]

Comment on attachment 8922589 [details]
Bug 1408737 - Upgrade reselect in Devtools shared libraries;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193702/diff/1-2/

Comment 5

[[e-mail]]

DAMP shows different perf inhancement place. 

`simple.netmonitor.requestsFinished.DAMP` get improved by 3%~6%, but complicated.netmonitor.close decreased 3%~6%

I think for netmonitor, requestsFinished time is more important than the close time, so it still worth the upgrade.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8922589 [details]
Bug 1408737 - Upgrade reselect in Devtools shared libraries;

https://reviewboard.mozilla.org/r/193702/#review200020

Yes, agree, it's worth to upgrade this lib.

R+

Thanks Fred for working on this!

Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb4f3467df5c
Upgrade reselect in Devtools shared libraries;r=Honza

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eb4f3467df5c