Closed Bug 1408738 Opened 2 years ago Closed 2 years ago

[macOS] [Photon] The Window Control Buttons could be placed some pixels to the right to match the Mock

Categories

(Firefox :: Theme, defect, P1)

Unspecified
macOS
defect

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox58 --- verified
firefox59 --- verified

People

(Reporter: mehmet.sahin, Assigned: daleharvey)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(6 files)

Attached image actual.png
macOS 10.12.6
58.0a1 (2017-10-14) (64-Bit)

STR:

1.) Open a new Window or new Private Window
2.) Take a look at the Window Control Buttons
3.) Compare the position of the Buttons with the Mock from http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html or with Safari or Chrome

Expected: The Window Control Buttons could be placed some pixels to the right to match the Mock or Safari or Chrome

Actual: They are placed too far left.
Attached image Mock.png
Attached image Safari_Chrome.png
QA Whiteboard: [photon-visual][triage]
QA Whiteboard: [photon-visual][triage]
Whiteboard: [photon-visual][triage]
Priority: -- → P4
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Priority: P4 → P3
Flags: qe-verify+
Assignee: nobody → dharvey
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8927817 [details]
Bug 1408738 - Give more left margin to window controls.

https://reviewboard.mozilla.org/r/199116/#review204176

Seems good, thank you!
Attachment #8927817 - Flags: review?(jhofmann) → review+
Hi Johann, hello Dale,

I placed the buttons in a mock by 6px further to the right and compared it with Safari and iTunes. It seems that 13px is 1px too far to the right. May be 12px would be enough to align it with Safari and iTunes. What do you think? Attached a screenshot. Thanks :-)
The extra 1px matched the spec, not all osx apps are consistent here, chrome is 1px to the left, spotify is like 5px further right but I think you are right if the spec is 1px off from where the native mac apps are then we may as well be consistent with them, updated the patch
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b414fcb0ff43
Give more left margin to window controls. r=johannh
(In reply to Dale Harvey (:daleharvey) from comment #7)
> The extra 1px matched the spec, not all osx apps are consistent here, chrome
> is 1px to the left, spotify is like 5px further right but I think you are
> right if the spec is 1px off from where the native mac apps are then we may
> as well be consistent with them, updated the patch

Great, thank you very much for your feedback and updating the patch :-)
https://hg.mozilla.org/mozilla-central/rev/b414fcb0ff43
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Attached image fixed.png
Looks great in latest Nightly. Tested on a Non-Retina Mac. The Control Buttons are now nicely aligned with e.g. Safari, iTunes, Photos, System Preferences. (See attachment.)

I would appreciate it, if this could be merged to FF58 :-) Or is this to risky? Thanks.
(In reply to Mehmet from comment #11)
> I would appreciate it, if this could be merged to FF58 :-) Or is this to
> risky? Thanks.

This doesn't seem risky at all. Let's do it.
Flags: needinfo?(dharvey)
Comment on attachment 8927817 [details]
Bug 1408738 - Give more left margin to window controls.

Approval Request Comment
[Feature/Bug causing the regression]: New visuals
[User impact if declined]: Inconsistent UX
[Is this code covered by automated tests?]: Nope
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Nope
[Why is the change risky/not risky?]: Minor CSS change
[String changes made/needed]:
Flags: needinfo?(dharvey)
Attachment #8927817 - Flags: approval-mozilla-beta?
Comment on attachment 8927817 [details]
Bug 1408738 - Give more left margin to window controls.

Polish UI and was verified in nightly. Beta58+.
Attachment #8927817 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I have managed to reproduce the issue described in comment 0 using Firefox 58.0a1 (BuildId:20171015220106).

This issue is verified fixed on Firefox 58.0b5 (BuildId:20171120142222) and Firefox 59.0a1 (BuildId:20171121100129) on macOS 10.12.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.