1408790 - The non-selected elements with ids should be lightened to the same color as the non-selected classes

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Comment 1

[Liam Hodgins]

Attachment: Bug 1408790 - The non-selected elements with ids should be lightened to the same color as the non-selected classes

Review commit: https://reviewboard.mozilla.org/r/189506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189506/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8918696 [details]
Bug 1408790 - The non-selected elements with ids should be lightened to the same color as the non-selected classes

https://reviewboard.mozilla.org/r/189506/#review199874

::: devtools/client/themes/breadcrumbs.css:166
(Diff revision 1)
>  
>  .theme-light .breadcrumbs-widget-item {
>    color: var(--theme-body-color);
>  }
>  
>  .breadcrumbs-widget-item-id {

So, we should just make this one rule since both items are gonna have the same color. I am also gonna just say we should hardcode it to var(--grey-40) for both light/dark theme. Maybe also do a check with Victoria afterwards. It seems to me that we were fine with the light grey in the id (--grey-40) in the light theme originally. The class is grey-30 in the dark theme, and having it as grey-40 also looks ok. Alternatively, we would have both the classes and id as grey-40 in the light theme and grey-30 in the dark theme.

.breadcrumbs-widget-item-classes,
.breadcrumbs-widget-item-id {
  color: var(--grey-40)
}

Comment 3

[Liam Hodgins]

Comment on attachment 8918696 [details]
Bug 1408790 - The non-selected elements with ids should be lightened to the same color as the non-selected classes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189506/diff/1-2/

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8918696 [details]
Bug 1408790 - The non-selected elements with ids should be lightened to the same color as the non-selected classes

https://reviewboard.mozilla.org/r/189506/#review202704

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac9d12e5587f
The non-selected elements with ids should be lightened to the same color as the non-selected classes r=gl

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ac9d12e5587f