1408815 - Session Restore for multiple windows via "Close all windows" on taskbar closes each window independently, causing only last window closed to restore

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect, P3)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I have 2 Firefox windows on 2 monitors, each with multiple tabs, on Windows 10.

On 56:
Right click Firefox icon on the Windows taskbar, select "Close all windows". After restart, both windows are restored.

On 57:
Right click Firefox icon, select "Close all windows". After restart, only one window is restored.

The workaround on 57 is to use "File -> Exit" to quit Firefox, then after restart, both windows will be restored.

[Tracking Requested - why for this release]:
This will cause user data to be lost when we move to 57, as I am sure that my second window data is no longer available, and digging through sessionstore-backup folder seems to only show the first window data.

Comment 1

[Liz Henry (:lizzard)]

Mike, can you find someone to investigate? This sounds like a potential data loss problem for users.

Comment 2

[Mike de Boer [:mikedeboer]]

Mike, do you know if we changed anything regarding the window close/ shutdown sequence that may allow sessionstore to register the first window to close successfully, instead of an application quit?

And Gary, two questions for you:
 1. Is the behavior different when you've got both windows on the same monitor?
 2. When you re-open Firefox and one window is restored, is the second window that didn't get restored in the list of 'Recently Closed Windows'?

Thanks!

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Mike de Boer [:mikedeboer] from comment #2)
>  1. Is the behavior different when you've got both windows on the same
> monitor?

No, same behaviour (only one window restored).

>  2. When you re-open Firefox and one window is restored, is the second
> window that didn't get restored in the list of 'Recently Closed Windows'?
> 

Yes, it's there! Oh luckily, apparently when I tested this time, my original window with lots of tabs didn't pop up. Luckily I found it there.

Comment 4

[Mike de Boer [:mikedeboer]]

Ok, that sounds we didn't actually lose data, which is nice to hear!

That leaves the fact that 'Close All Windows' opted from the OS' window menu does not follow the 'Quit Application' path, but starts closing windows regularly first. This makes me wonder... are you sure this started happening since Firefox 57 and not before it?

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

> are you sure this started happening since Firefox 57 and not before it?

I'm fairly sure, but not definite. It'll be nice if someone could retry my steps!

Comment 6

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

(In reply to Mike de Boer [:mikedeboer] from comment #2)
> Mike, do you know if we changed anything regarding the window close/
> shutdown sequence that may allow sessionstore to register the first window
> to close successfully, instead of an application quit?

Nothing comes to mind. I'll happily help comb through a regression range if we have one.

Comment 7

[Liz Henry (:lizzard)]

Andrei, can someone on your team try to reproduce the bug and/or find a regression window? Thanks!

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This is strange. I tried finding a regression window in recreated fresh profiles and "Close All Windows", after startup, seems to reopen only one window going way back to 20150101 32-bit builds. I'm not sure why 56 worked for my profile but it might seem that this isn't a 57-regression after all.

In any case, shouldn't "Close All Windows" then reopen all windows post-startup, taking the same path as the "Exit" power button?

Comment 9

[Mike de Boer [:mikedeboer]]

I think it's a wildly confusing option indeed, because on Windows and Linux it effectively means 'Quit Application'. Only on OSX this option has (relative) merit, because in that different windowing system it actually means something.

I'm going to morph this bug thusly and keep the priority flag the same.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Jared, reading the comments here, it doesn't seem like a new regression in 57. It also doesn't seem like a fix we'd include in 57. Resolving this as wontfix. Please let me know if you think this is a must fix.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

The "Close All Windows" option is something that the Windows operating system provides. This isn't something that I believe we can simply remove. Not to mention, removing it will be annoying to users who actually do intend to close all their windows quickly without regard to restoring all of the windows.

"Close All Windows" only appears on Windows 10 when the taskbar is full past some threshold where the windows get merged together, also if the "Combine taskbar buttons" setting is set to "Always, hide labels".

We might get a Windows message that all windows are being closed from this, and in that case we should just add platform support to treat this as an application quit. This isn't new behavior for Windows though, and thus I don't see the urgency to remove it.

I'll mostly restore the original bug summary.

Comment 12

[Adrian Florinescu [:aflorinescu]]

Removing the NI for QA and qe+ flag, since IMO, this bug means a bit of refactoring around how we close/restore Firefox windows under Windows/Linux OSes. Please re-set the flags if my understanding is incorrect.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 14

[Worcester12345]

Wait, we deal with old bugs by lowering the priority? Shouldn't it be the EXACT OPPOSITE? If this were a doctor's office, the patient would be dead.

Comment 15

[Simona Badau, Desktop QA]

This behavior is no longer encountered on the latest Firefox versions (Firefox 78.15.0 esr, Firefox 93, Firefox 94 beta 5, and Nightly 95.0a1) - all the windows and tabs are now restored if choosing to "Close all windows" from the Windows Taskbar. Setting this to Resolved Worksforme.