Closed Bug 1408823 Opened 5 years ago Closed 2 years ago

Android should limit the number of tabs synced.

Categories

(Firefox for Android Graveyard :: Android Sync, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: tcsc, Unassigned)

References

Details

Upon further thinking after the audit in bug 1407438, I can't actually make Fennec respect the limit for synced tabs, since there's no logic similar to how Desktop limits the number of tabs we sync. 

Specifically, in Desktop, this code[0] makes an effort to ensure that we aren't going to send too many tabs to actually sync, and limit it to how many we'd successfully be able to send.

Androids equivalent[1] (or [2] depending on how you squint) doesn't do any similar checks, and so will just outright fail to post the record if too many tabs are open.

[0]: http://searchfox.org/mozilla-central/source/services/sync/modules/engines/tabs.js#230-239

[1]: http://searchfox.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/repositories/domain/TabsRecord.java#64-70

[2]: http://searchfox.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/repositories/android/FennecTabsRepository.java#340
Bob, is it possible for you to determine from the server logs how many android devices are attempting to post records to the "tabs" collection which are rejected for being too large?
Flags: needinfo?(bobm)
(In reply to Mark Hammond [:markh] from comment #1)
Yes.  How much data are you looking for?
Flags: needinfo?(bobm) → needinfo?(markh)
Bob, Thom and I discussed in IRC and it seems that neither the server logs nor client telemetry are able to help us here :( Given we know this *could* happen and were just looking for evidence it doesn't happen often enough to justify the work, sadly I think this means we should probably just do it.
Flags: needinfo?(markh)
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.