Closed
Bug 1408893
Opened 7 years ago
Closed 6 years ago
Enable browser_webconsole_eval_in_debugger_stackframe2.js in the new console frontend
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: [newconsole-mvp])
Attachments
(1 file)
No description provided.
Updated•7 years ago
|
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8940185 [details] Bug 1408893 - Enable browser_webconsole_eval_in_debugger_stackframe2.js in the new console frontend; . https://reviewboard.mozilla.org/r/210496/#review216240 ::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_eval_in_debugger_stackframe2.js:57 (Diff revision 1) > - '"globalFooBug783499foo2SecondCall"'); > + jsterm.execute("foo + foo2"); > + message = await onMessageReceived; > + ok(message, "`foo + foo2` was evaluated as expected with debugger paused"); > + > + info("Checking the first command, which is the last to resolve since it paused"); > + ok(firstCallEvaluationResult === unresolvedSymbol, "firstCall was not evaluated yet"); Nit: you could use `is` here
Attachment #8940185 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8940185 [details] Bug 1408893 - Enable browser_webconsole_eval_in_debugger_stackframe2.js in the new console frontend; . https://reviewboard.mozilla.org/r/210496/#review216240 > Nit: you could use `is` here I tried but the test was failing : ``` TEST-UNEXPECTED-FAIL | devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_eval_in_debugger_stackframe2.js | Uncaught exception - at chrome://mochikit/content/browser-test.js:1269 - TypeError: can't convert symbol to string Stack trace: test_is@chrome://mochikit/content/browser-test.js:1269:5 @chrome://mochitests/content/browser/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_eval_in_debugger_stackframe2.js:57:3 Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1065:21 Tester_execTest@chrome://mochikit/content/browser-test.js:1056:9 Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:956:9 SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59 ``` Maybe I should file a bug against browser-test.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/253e9d9481f5 Enable browser_webconsole_eval_in_debugger_stackframe2.js in the new console frontend; r=bgrins.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/253e9d9481f5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•