1408916 - Enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1408916 - Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; .

Review commit: https://reviewboard.mozilla.org/r/191010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191010/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8920025 [details]
Bug 1408916 - Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; .

https://reviewboard.mozilla.org/r/191010/#review196444

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_autocomplete-properties-with-non-alphanumeric-names.js:12
(Diff revision 1)
>  
>  // Test that properties starting with underscores or dollars can be
>  // autocompleted (bug 967468).
> +const TEST_URI = "data:text/html;charset=utf8,test autocompletion with $ or _";
>  
>  add_task(function* () {

Nit: can we switch to async/await in this task function as well?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8920025 [details]
Bug 1408916 - Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191010/diff/1-2/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8920025 [details]
Bug 1408916 - Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; .

https://reviewboard.mozilla.org/r/191010/#review196444

> Nit: can we switch to async/await in this task function as well?

Done !

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bbd725cdba3
Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; r=bgrins.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3bbd725cdba3