Closed Bug 1408916 Opened 2 years ago Closed 2 years ago

Enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 1400847
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8920025 [details]
Bug 1408916 - Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; .

https://reviewboard.mozilla.org/r/191010/#review196444

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_autocomplete-properties-with-non-alphanumeric-names.js:12
(Diff revision 1)
>  
>  // Test that properties starting with underscores or dollars can be
>  // autocompleted (bug 967468).
> +const TEST_URI = "data:text/html;charset=utf8,test autocompletion with $ or _";
>  
>  add_task(function* () {

Nit: can we switch to async/await in this task function as well?
Attachment #8920025 - Flags: review?(bgrinstead) → review+
Comment on attachment 8920025 [details]
Bug 1408916 - Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; .

https://reviewboard.mozilla.org/r/191010/#review196444

> Nit: can we switch to async/await in this task function as well?

Done !
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bbd725cdba3
Rename and enable browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js in the new console frontend; r=bgrins.
https://hg.mozilla.org/mozilla-central/rev/3bbd725cdba3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.